[Public]
Yes, I missed that they can be merged separately. I’ll reorder the patch list
when merging them.
Regards,
Prike
> -----Original Message-----
> From: Koenig, Christian <[email protected]>
> Sent: Friday, January 9, 2026 5:09 PM
> To: Liang, Prike <[email protected]>; [email protected]
> Cc: Deucher, Alexander <[email protected]>; [email protected]
> Subject: Re: [PATCH 2/2] drm/amdgpu: validate the flush_gpu_tlb_pasid()
>
> On 1/9/26 09:25, Prike Liang wrote:
> > Validate flush_gpu_tlb_pasid() availability before flushing tlb.
> >
> > Signed-off-by: Prike Liang <[email protected]>
> > Reviewed-by: Christian König <[email protected]>
>
> This patch set needs to be re-ordered, e.g. this patch here first and then
> the other
> one.
>
> Otherwise you have a state in between where it is broken again.
>
> Apart from that looks good to me.
>
> Regards,
> Christian.
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> > index 6d7b8bb953ae..0e67fa4338ff 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> > @@ -780,6 +780,10 @@ int amdgpu_gmc_flush_gpu_tlb_pasid(struct
> amdgpu_device *adev, uint16_t pasid,
> > return 0;
> >
> > if (!adev->gmc.flush_pasid_uses_kiq || !ring->sched.ready) {
> > +
> > + if (!adev->gmc.gmc_funcs->flush_gpu_tlb_pasid)
> > + return 0;
> > +
> > if (adev->gmc.flush_tlb_needs_extra_type_2)
> > adev->gmc.gmc_funcs->flush_gpu_tlb_pasid(adev, pasid,
> > 2, all_hub,
