Hi, kernel test robot noticed the following build errors:
[auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on daeinki-drm-exynos/exynos-drm-next drm/drm-next drm-tip/drm-tip next-20260115] [cannot apply to drm-i915/for-linux-next drm-i915/for-linux-next-fixes linus/master v6.19-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/sunpeng-li-amd-com/drm-amd-display-Implement-prepare_vblank_enable-callback/20260110-032355 base: https://gitlab.freedesktop.org/drm/misc/kernel.git drm-misc-next patch link: https://lore.kernel.org/r/20260109192027.116325-2-sunpeng.li%40amd.com patch subject: [PATCH v3 2/2] drm/amd/display: Implement prepare_vblank_enable callback config: csky-allmodconfig (https://download.01.org/0day-ci/archive/20260116/[email protected]/config) compiler: csky-linux-gcc (GCC) 15.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260116/[email protected]/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <[email protected]> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ All errors (new ones prefixed by >>): In file included from include/linux/preempt.h:11, from include/linux/spinlock.h:56, from include/drm/drm_crtc.h:28, from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_crc.c:27: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_crc.c: In function 'amdgpu_dm_crtc_set_crc_source': >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_crc.c:659:38: >> error: 'dm' undeclared (first use in this function); did you mean 'dc'? 659 | scoped_guard(mutex, &dm->dc_lock) { | ^~ include/linux/cleanup.h:433:34: note: in definition of macro '__scoped_guard' 433 | for (CLASS(_name, scope)(args); \ | ^~~~ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_crc.c:659:17: note: in expansion of macro 'scoped_guard' 659 | scoped_guard(mutex, &dm->dc_lock) { | ^~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_crc.c:659:38: note: each undeclared identifier is reported only once for each function it appears in 659 | scoped_guard(mutex, &dm->dc_lock) { | ^~ include/linux/cleanup.h:433:34: note: in definition of macro '__scoped_guard' 433 | for (CLASS(_name, scope)(args); \ | ^~~~ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_crc.c:659:17: note: in expansion of macro 'scoped_guard' 659 | scoped_guard(mutex, &dm->dc_lock) { | ^~~~~~~~~~~~ vim +659 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_crc.c 542 543 int amdgpu_dm_crtc_set_crc_source(struct drm_crtc *crtc, const char *src_name) 544 { 545 enum amdgpu_dm_pipe_crc_source source = dm_parse_crc_source(src_name); 546 enum amdgpu_dm_pipe_crc_source cur_crc_src; 547 struct drm_crtc_commit *commit; 548 struct dm_crtc_state *crtc_state; 549 struct drm_device *drm_dev = crtc->dev; 550 #if defined(CONFIG_DRM_AMD_SECURE_DISPLAY) 551 struct amdgpu_device *adev = drm_to_adev(drm_dev); 552 struct amdgpu_display_manager *dm = &adev->dm; 553 #endif 554 struct amdgpu_crtc *acrtc = to_amdgpu_crtc(crtc); 555 struct drm_dp_aux *aux = NULL; 556 bool enable = false; 557 bool enabled = false; 558 int ret = 0; 559 560 if (source < 0) { 561 DRM_DEBUG_DRIVER("Unknown CRC source %s for CRTC%d\n", 562 src_name, crtc->index); 563 return -EINVAL; 564 } 565 566 ret = drm_modeset_lock(&crtc->mutex, NULL); 567 if (ret) 568 return ret; 569 570 spin_lock(&crtc->commit_lock); 571 commit = list_first_entry_or_null(&crtc->commit_list, 572 struct drm_crtc_commit, commit_entry); 573 if (commit) 574 drm_crtc_commit_get(commit); 575 spin_unlock(&crtc->commit_lock); 576 577 if (commit) { 578 /* 579 * Need to wait for all outstanding programming to complete 580 * in commit tail since it can modify CRC related fields and 581 * hardware state. Since we're holding the CRTC lock we're 582 * guaranteed that no other commit work can be queued off 583 * before we modify the state below. 584 */ 585 ret = wait_for_completion_interruptible_timeout( 586 &commit->hw_done, 10 * HZ); 587 if (ret) 588 goto cleanup; 589 } 590 591 enable = amdgpu_dm_is_valid_crc_source(source); 592 crtc_state = to_dm_crtc_state(crtc->state); 593 spin_lock_irq(&drm_dev->event_lock); 594 cur_crc_src = acrtc->dm_irq_params.crc_src; 595 spin_unlock_irq(&drm_dev->event_lock); 596 597 /* 598 * USER REQ SRC | CURRENT SRC | BEHAVIOR 599 * ----------------------------- 600 * None | None | Do nothing 601 * None | CRTC | Disable CRTC CRC, set default to dither 602 * None | DPRX | Disable DPRX CRC, need 'aux', set default to dither 603 * None | CRTC DITHER | Disable CRTC CRC 604 * None | DPRX DITHER | Disable DPRX CRC, need 'aux' 605 * CRTC | XXXX | Enable CRTC CRC, no dither 606 * DPRX | XXXX | Enable DPRX CRC, need 'aux', no dither 607 * CRTC DITHER | XXXX | Enable CRTC CRC, set dither 608 * DPRX DITHER | XXXX | Enable DPRX CRC, need 'aux', set dither 609 */ 610 if (dm_is_crc_source_dprx(source) || 611 (source == AMDGPU_DM_PIPE_CRC_SOURCE_NONE && 612 dm_is_crc_source_dprx(cur_crc_src))) { 613 struct amdgpu_dm_connector *aconn = NULL; 614 struct drm_connector *connector; 615 struct drm_connector_list_iter conn_iter; 616 617 drm_connector_list_iter_begin(crtc->dev, &conn_iter); 618 drm_for_each_connector_iter(connector, &conn_iter) { 619 if (!connector->state || connector->state->crtc != crtc) 620 continue; 621 622 if (connector->connector_type == DRM_MODE_CONNECTOR_WRITEBACK) 623 continue; 624 625 aconn = to_amdgpu_dm_connector(connector); 626 break; 627 } 628 drm_connector_list_iter_end(&conn_iter); 629 630 if (!aconn) { 631 DRM_DEBUG_DRIVER("No amd connector matching CRTC-%d\n", crtc->index); 632 ret = -EINVAL; 633 goto cleanup; 634 } 635 636 aux = (aconn->mst_output_port) ? &aconn->mst_output_port->aux : &aconn->dm_dp_aux.aux; 637 638 if (!aux) { 639 DRM_DEBUG_DRIVER("No dp aux for amd connector\n"); 640 ret = -EINVAL; 641 goto cleanup; 642 } 643 644 if ((aconn->base.connector_type != DRM_MODE_CONNECTOR_DisplayPort) && 645 (aconn->base.connector_type != DRM_MODE_CONNECTOR_eDP)) { 646 DRM_DEBUG_DRIVER("No DP connector available for CRC source\n"); 647 ret = -EINVAL; 648 goto cleanup; 649 } 650 651 } 652 653 /* 654 * Reading the CRC requires the vblank interrupt handler to be 655 * enabled. Keep a reference until CRC capture stops. 656 */ 657 enabled = amdgpu_dm_is_valid_crc_source(cur_crc_src); 658 if (!enabled && enable) { > 659 scoped_guard(mutex, &dm->dc_lock) { 660 dc_exit_ips_for_hw_access(dm->dc); 661 ret = drm_crtc_vblank_get(crtc); 662 } 663 664 if (ret) 665 goto cleanup; 666 } 667 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
