[AMD Official Use Only - AMD Internal Distribution Only]
> -----Original Message-----
> From: Alex Deucher <[email protected]>
> Sent: Friday, January 23, 2026 4:05 AM
> To: Zhang, Jesse(Jie) <[email protected]>
> Cc: [email protected]; Deucher, Alexander
> <[email protected]>; Koenig, Christian <[email protected]>
> Subject: Re: [PATCH 1/9] drm/amd/amdgpu: Add update_mqd callback to
> amdgpu_mqd struct
>
> On Thu, Jan 22, 2026 at 3:57 AM Jesse.Zhang <[email protected]> wrote:
> >
> > Extend the amdgpu_mqd structure with a new 'update_mqd' callback to
> > support runtime updates of MQD properties for user queues
> >
> > Signed-off-by: Jesse Zhang <[email protected]>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> > b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> > index 11a36c132905..f997fa17e8bd 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> > @@ -815,6 +815,8 @@ struct amdgpu_mqd {
> > unsigned mqd_size;
> > int (*init_mqd)(struct amdgpu_device *adev, void *mqd,
> > struct amdgpu_mqd_prop *p);
> > + int (*update_mqd)(struct amdgpu_device *adev, void *mqd,
> > + struct amdgpu_mqd_prop *p);
>
> Do we actually need a new callback, or can we just call init_mqd() again with
> updated parameters?
>
[Zhang, Jesse(Jie)]
The `update_mqd` function only contains the MQD parameter, which changes
dynamically at runtime.
However, we can also directly call the `init_mqd` function to update all
parameters.
I will update the patch and remove the `update_mqd` function.
Thanks
Jesse
> Alex
>
> > };
> >
> > struct amdgpu_pcie_reset_ctx {
> > --
> > 2.49.0
> >
