Re: [PATCH] drm/amdgpu: Fix memory leak in amdgpu_acpi_enumerate_xcc()

[Alex Deucher]

Applied.  Thanks!

On Thu, Jan 29, 2026 at 5:15 AM Lazar, Lijo <lijo.la...@amd.com> wrote:
>
>
>
> On 29-Jan-26 2:55 PM, Zilin Guan wrote:
> > In amdgpu_acpi_enumerate_xcc(), if amdgpu_acpi_dev_init() returns -ENOMEM,
> > the function returns directly without releasing the allocated xcc_info,
> > resulting in a memory leak.
> >
> > Fix this by ensuring that xcc_info is properly freed in the error paths.
> >
> > Compile tested only. Issue found using a prototype static analysis tool
> > and code review.
> >
> > Fixes: 4d5275ab0b18 ("drm/amdgpu: Add parsing of acpi xcc objects")
> > Signed-off-by: Zilin Guan <zi...@seu.edu.cn>
>
> Reviewed-by: Lijo Lazar <lijo.la...@amd.com>
>
> Thanks,
> Lijo
>
>
> > ---
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c 
> > b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
> > index d31460a9e958..7c9d8a6d0bfd 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
> > @@ -1135,8 +1135,10 @@ static int amdgpu_acpi_enumerate_xcc(void)
> >               if (!dev_info)
> >                       ret = amdgpu_acpi_dev_init(&dev_info, xcc_info, sbdf);
> >
> > -             if (ret == -ENOMEM)
> > +             if (ret == -ENOMEM) {
> > +                     kfree(xcc_info);
> >                       return ret;
> > +             }
> >
> >               if (!dev_info) {
> >                       kfree(xcc_info);
>