On Wed, Feb 4, 2026 at 10:47 AM Victor Zhao <[email protected]> wrote:
>
> sdma ring reset is not supported in SRIOV. kfd driver does not check
> reset mask, and could queue sdma ring reset during unmap_queues_cpsch.
>
> Avoid the ring reset for sriov.
>
> Signed-off-by: Victor Zhao <[email protected]>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
> index 8b8a04138711..321310ba2c08 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
> @@ -558,6 +558,9 @@ int amdgpu_sdma_reset_engine(struct amdgpu_device *adev, 
> uint32_t instance_id,
>         struct amdgpu_ring *gfx_ring = &sdma_instance->ring;
>         struct amdgpu_ring *page_ring = &sdma_instance->page;
>
> +       if (amdgpu_sriov_vf(adev))
> +               return -EOPNOTSUPP;

How about !amdgpu_ring_is_reset_type_supported(ring,
AMDGPU_RESET_TYPE_PER_QUEUE) instead in case this ever gets enabled on
SR-IOV?  Either way:
Reviewed-by: Alex Deucher <[email protected]>

> +
>         mutex_lock(&sdma_instance->engine_reset_mutex);
>
>         if (!caller_handles_kernel_queues) {
> --
> 2.25.1
>

Reply via email to