[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang <[email protected]>
Best Regards, Kevin -----Original Message----- From: Bart Van Assche <[email protected]> Sent: Tuesday, February 24, 2026 6:00 AM To: Peter Zijlstra <[email protected]> Cc: Ingo Molnar <[email protected]>; Will Deacon <[email protected]>; Boqun Feng <[email protected]>; Waiman Long <[email protected]>; [email protected]; Marco Elver <[email protected]>; Christoph Hellwig <[email protected]>; Steven Rostedt <[email protected]>; Nick Desaulniers <[email protected]>; Nathan Chancellor <[email protected]>; Kees Cook <[email protected]>; Jann Horn <[email protected]>; Bart Van Assche <[email protected]>; Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; Wang, Yang(Kevin) <[email protected]>; Zhang, Hawking <[email protected]>; [email protected] Subject: [PATCH 07/62] drm/amdgpu: Unlock a mutex before destroying it [You don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] From: Bart Van Assche <[email protected]> Mutexes must be unlocked before these are destroyed. This has been detected by the Clang thread-safety analyzer. Cc: Alex Deucher <[email protected]> Cc: Christian König <[email protected]> Cc: Yang Wang <[email protected]> Cc: Hawking Zhang <[email protected]> Cc: [email protected] Fixes: f5e4cc8461c4 ("drm/amdgpu: implement RAS ACA driver framework") Signed-off-by: Bart Van Assche <[email protected]> --- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c index afe5ca81beec..db7858fe0c3d 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c @@ -641,6 +641,7 @@ static void aca_error_fini(struct aca_error *aerr) aca_bank_error_remove(aerr, bank_error); out_unlock: + mutex_unlock(&aerr->lock); mutex_destroy(&aerr->lock); }
