On Mon 02-03-26 15:25:14, Jeff Layton wrote:
> Now that i_ino is u64 and the PRIino format macro has been removed,
> replace all uses in minix with the concrete format strings.
> 
> Signed-off-by: Jeff Layton <[email protected]>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

                                                                Honza

> ---
>  fs/minix/inode.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/minix/inode.c b/fs/minix/inode.c
> index 
> d92059227d273564c86f100dea3366be4509090b..838b072b6cf0b54c955320916ac996e72f994a14
>  100644
> --- a/fs/minix/inode.c
> +++ b/fs/minix/inode.c
> @@ -36,7 +36,7 @@ void __minix_error_inode(struct inode *inode, const char 
> *function,
>       vaf.fmt = fmt;
>       vaf.va = &args;
>       printk(KERN_CRIT "minix-fs error (device %s): %s:%d: "
> -            "inode #%" PRIino "u: comm %s: %pV\n",
> +            "inode #%llu: comm %s: %pV\n",
>              inode->i_sb->s_id, function, line, inode->i_ino,
>              current->comm, &vaf);
>       va_end(args);
> @@ -520,7 +520,7 @@ void minix_set_inode(struct inode *inode, dev_t rdev)
>                  S_ISFIFO(inode->i_mode) || S_ISSOCK(inode->i_mode)) {
>               init_special_inode(inode, inode->i_mode, rdev);
>       } else {
> -             printk(KERN_DEBUG "MINIX-fs: Invalid file type 0%04o for inode 
> %" PRIino "u.\n",
> +             printk(KERN_DEBUG "MINIX-fs: Invalid file type 0%04o for inode 
> %llu.\n",
>                      inode->i_mode, inode->i_ino);
>               make_bad_inode(inode);
>       }
> @@ -542,7 +542,7 @@ static struct inode *V1_minix_iget(struct inode *inode)
>               return ERR_PTR(-EIO);
>       }
>       if (raw_inode->i_nlinks == 0) {
> -             printk("MINIX-fs: deleted inode referenced: %" PRIino "u\n",
> +             printk("MINIX-fs: deleted inode referenced: %llu\n",
>                      inode->i_ino);
>               brelse(bh);
>               iget_failed(inode);
> @@ -580,7 +580,7 @@ static struct inode *V2_minix_iget(struct inode *inode)
>               return ERR_PTR(-EIO);
>       }
>       if (raw_inode->i_nlinks == 0) {
> -             printk("MINIX-fs: deleted inode referenced: %" PRIino "u\n",
> +             printk("MINIX-fs: deleted inode referenced: %llu\n",
>                      inode->i_ino);
>               brelse(bh);
>               iget_failed(inode);
> @@ -692,7 +692,7 @@ static int minix_write_inode(struct inode *inode, struct 
> writeback_control *wbc)
>       if (wbc->sync_mode == WB_SYNC_ALL && buffer_dirty(bh)) {
>               sync_dirty_buffer(bh);
>               if (buffer_req(bh) && !buffer_uptodate(bh)) {
> -                     printk("IO error syncing minix inode [%s:%08" PRIino 
> "x]\n",
> +                     printk("IO error syncing minix inode [%s:%08llx]\n",
>                               inode->i_sb->s_id, inode->i_ino);
>                       err = -EIO;
>               }
> 
> -- 
> 2.53.0
> 
-- 
Jan Kara <[email protected]>
SUSE Labs, CR

Reply via email to