Re: [PATCH v2 23/30] drm/amd/display: Move FPU Guards From DML To DC - Part 1

[Ard Biesheuvel]

On Wed, 6 May 2026, at 11:45, Ostrowski, Rafal wrote:
> On Tue, 05 May 2026, at 12:55, Ard Biesheuvel<a...@kernel.org> wrote:
>> This looks wrong to me. If _LINUX_FPU_COMPILATION_UNIT is #define'd,
>> it means the code runs within a DC_FP_START/END pair, and so doing
>> nothing will not re-enable preemption.
>> 
>> I think this #define should probably just be dropped. If that breaks
>> the build, it means the code is already fundamentally broken and
>> needs fixing.
>
> Hi Ard,
>
> I appreciate your feedback. Yes, you are right, it is not needed.
> I decided to replace it with:
> #define DC_RUN_WITH_PREEMPTION_ENABLED(code)  BUILD_BUG()
> I compiled it on various supported platforms without issues.
> Is that ok to you? If yes, I will work on patch.
>

Yes, that is fine.