Only allocate entries from the GTT manager when the
VCE GTT node is not allocated yet. This prevents the
possibility of allocating them multiple times, which
causes issues during GPU reset and suspend/resume.

Fixes: 66a80158aa2a ("amdgpu/vce: use amdgpu_gtt_mgr_alloc_entries")
Signed-off-by: Timur Kristóf <[email protected]>
Reviewed-by: Christian König <[email protected]>
---
 drivers/gpu/drm/amd/amdgpu/vce_v1_0.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v1_0.c 
b/drivers/gpu/drm/amd/amdgpu/vce_v1_0.c
index a49f11be74b2..92c3cf3fce4f 100644
--- a/drivers/gpu/drm/amd/amdgpu/vce_v1_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vce_v1_0.c
@@ -545,11 +545,13 @@ static int vce_v1_0_ensure_vcpu_bo_32bit_addr(struct 
amdgpu_device *adev)
        if (adev->gmc.vram_start < adev->gmc.gart_start)
                return amdgpu_bo_gpu_offset(adev->vce.vcpu_bo) <= 
max_vcpu_bo_addr ? 0 : -EINVAL;
 
-       r = amdgpu_gtt_mgr_alloc_entries(&adev->mman.gtt_mgr,
-                                        &adev->vce.gart_node, num_pages,
-                                        DRM_MM_INSERT_LOW);
-       if (r)
-               return r;
+       if (!drm_mm_node_allocated(&adev->vce.gart_node)) {
+               r = amdgpu_gtt_mgr_alloc_entries(&adev->mman.gtt_mgr,
+                                                &adev->vce.gart_node, 
num_pages,
+                                                DRM_MM_INSERT_LOW);
+               if (r)
+                       return r;
+       }
 
        vce_gart_start_offs = 
amdgpu_gtt_node_to_byte_offset(&adev->vce.gart_node);
 
-- 
2.54.0

Reply via email to