On 5/13/26 18:30, Timur Kristóf wrote: > Whether retry faults are actually enabled, is determined by > the amdgpu_gmc_noretry_set() function. The rest of the code > base should use gmc->noretry instead of the module parameter. > > Signed-off-by: Timur Kristóf <[email protected]>
Reviewed-by: Christian König <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/gfxhub_v11_5_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/gfxhub_v12_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0_3.c | 2 +- > drivers/gpu/drm/amd/amdgpu/mmhub_v3_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/mmhub_v3_0_1.c | 2 +- > drivers/gpu/drm/amd/amdgpu/mmhub_v3_0_2.c | 2 +- > drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c | 2 +- > drivers/gpu/drm/amd/amdgpu/mmhub_v4_1_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/mmhub_v4_2_0.c | 2 +- > 10 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfxhub_v11_5_0.c > b/drivers/gpu/drm/amd/amdgpu/gfxhub_v11_5_0.c > index f9949fedfbb9..f845ba698b40 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfxhub_v11_5_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfxhub_v11_5_0.c > @@ -321,7 +321,7 @@ static void gfxhub_v11_5_0_setup_vmid_config(struct > amdgpu_device *adev) > /* Send no-retry XNACK on fault to suppress VM fault storm. */ > tmp = REG_SET_FIELD(tmp, GCVM_CONTEXT1_CNTL, > RETRY_PERMISSION_OR_INVALID_PAGE_FAULT, > - !amdgpu_noretry); > + !adev->gmc.noretry); > WREG32_SOC15_OFFSET(GC, 0, regGCVM_CONTEXT1_CNTL, > i * hub->ctx_distance, tmp); > WREG32_SOC15_OFFSET(GC, 0, > regGCVM_CONTEXT1_PAGE_TABLE_START_ADDR_LO32, > diff --git a/drivers/gpu/drm/amd/amdgpu/gfxhub_v12_0.c > b/drivers/gpu/drm/amd/amdgpu/gfxhub_v12_0.c > index 7609b9cecae8..ba78b5a1a7cd 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfxhub_v12_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfxhub_v12_0.c > @@ -326,7 +326,7 @@ static void gfxhub_v12_0_setup_vmid_config(struct > amdgpu_device *adev) > /* Send no-retry XNACK on fault to suppress VM fault storm. */ > tmp = REG_SET_FIELD(tmp, GCVM_CONTEXT1_CNTL, > RETRY_PERMISSION_OR_INVALID_PAGE_FAULT, > - !amdgpu_noretry); > + !adev->gmc.noretry); > WREG32_SOC15_OFFSET(GC, 0, regGCVM_CONTEXT1_CNTL, > i * hub->ctx_distance, tmp); > WREG32_SOC15_OFFSET(GC, 0, > regGCVM_CONTEXT1_PAGE_TABLE_START_ADDR_LO32, > diff --git a/drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0.c > b/drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0.c > index abe30c8bd2ba..631f99e3741a 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0.c > @@ -318,7 +318,7 @@ static void gfxhub_v3_0_setup_vmid_config(struct > amdgpu_device *adev) > /* Send no-retry XNACK on fault to suppress VM fault storm. */ > tmp = REG_SET_FIELD(tmp, GCVM_CONTEXT1_CNTL, > RETRY_PERMISSION_OR_INVALID_PAGE_FAULT, > - !amdgpu_noretry); > + !adev->gmc.noretry); > WREG32_SOC15_OFFSET(GC, 0, regGCVM_CONTEXT1_CNTL, > i * hub->ctx_distance, tmp); > WREG32_SOC15_OFFSET(GC, 0, > regGCVM_CONTEXT1_PAGE_TABLE_START_ADDR_LO32, > diff --git a/drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0_3.c > b/drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0_3.c > index b3ef6e71811f..8a87410ce016 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0_3.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0_3.c > @@ -323,7 +323,7 @@ static void gfxhub_v3_0_3_setup_vmid_config(struct > amdgpu_device *adev) > /* Send no-retry XNACK on fault to suppress VM fault storm. */ > tmp = REG_SET_FIELD(tmp, GCVM_CONTEXT1_CNTL, > RETRY_PERMISSION_OR_INVALID_PAGE_FAULT, > - !amdgpu_noretry); > + !adev->gmc.noretry); > WREG32_SOC15_OFFSET(GC, 0, regGCVM_CONTEXT1_CNTL, > i * hub->ctx_distance, tmp); > WREG32_SOC15_OFFSET(GC, 0, > regGCVM_CONTEXT1_PAGE_TABLE_START_ADDR_LO32, > diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v3_0.c > b/drivers/gpu/drm/amd/amdgpu/mmhub_v3_0.c > index 3d82cfa0f1b5..ab56dd15b3f5 100644 > --- a/drivers/gpu/drm/amd/amdgpu/mmhub_v3_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v3_0.c > @@ -340,7 +340,7 @@ static void mmhub_v3_0_setup_vmid_config(struct > amdgpu_device *adev) > /* Send no-retry XNACK on fault to suppress VM fault storm. */ > tmp = REG_SET_FIELD(tmp, MMVM_CONTEXT1_CNTL, > RETRY_PERMISSION_OR_INVALID_PAGE_FAULT, > - !amdgpu_noretry); > + !adev->gmc.noretry); > WREG32_SOC15_OFFSET(MMHUB, 0, regMMVM_CONTEXT1_CNTL, > i * hub->ctx_distance, tmp); > WREG32_SOC15_OFFSET(MMHUB, 0, > regMMVM_CONTEXT1_PAGE_TABLE_START_ADDR_LO32, > diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v3_0_1.c > b/drivers/gpu/drm/amd/amdgpu/mmhub_v3_0_1.c > index a1b0b7b39a42..6522a89379b7 100644 > --- a/drivers/gpu/drm/amd/amdgpu/mmhub_v3_0_1.c > +++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v3_0_1.c > @@ -333,7 +333,7 @@ static void mmhub_v3_0_1_setup_vmid_config(struct > amdgpu_device *adev) > /* Send no-retry XNACK on fault to suppress VM fault storm. */ > tmp = REG_SET_FIELD(tmp, MMVM_CONTEXT1_CNTL, > RETRY_PERMISSION_OR_INVALID_PAGE_FAULT, > - !amdgpu_noretry); > + !adev->gmc.noretry); > WREG32_SOC15_OFFSET(MMHUB, 0, regMMVM_CONTEXT1_CNTL, > i * hub->ctx_distance, tmp); > WREG32_SOC15_OFFSET(MMHUB, 0, > regMMVM_CONTEXT1_PAGE_TABLE_START_ADDR_LO32, > diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v3_0_2.c > b/drivers/gpu/drm/amd/amdgpu/mmhub_v3_0_2.c > index 34e8dbd47c0f..23cf95783264 100644 > --- a/drivers/gpu/drm/amd/amdgpu/mmhub_v3_0_2.c > +++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v3_0_2.c > @@ -339,7 +339,7 @@ static void mmhub_v3_0_2_setup_vmid_config(struct > amdgpu_device *adev) > /* Send no-retry XNACK on fault to suppress VM fault storm. */ > tmp = REG_SET_FIELD(tmp, MMVM_CONTEXT1_CNTL, > RETRY_PERMISSION_OR_INVALID_PAGE_FAULT, > - !amdgpu_noretry); > + !adev->gmc.noretry); > WREG32_SOC15_OFFSET(MMHUB, 0, regMMVM_CONTEXT1_CNTL, > i * hub->ctx_distance, tmp); > WREG32_SOC15_OFFSET(MMHUB, 0, > regMMVM_CONTEXT1_PAGE_TABLE_START_ADDR_LO32, > diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c > b/drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c > index cfce7e1297d4..98568c72c2be 100644 > --- a/drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c > +++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c > @@ -451,7 +451,7 @@ static void mmhub_v3_3_setup_vmid_config(struct > amdgpu_device *adev) > /* Send no-retry XNACK on fault to suppress VM fault storm. */ > tmp = REG_SET_FIELD(tmp, MMVM_CONTEXT1_CNTL, > RETRY_PERMISSION_OR_INVALID_PAGE_FAULT, > - !amdgpu_noretry); > + !adev->gmc.noretry); > WREG32_SOC15_OFFSET(MMHUB, 0, regMMVM_CONTEXT1_CNTL, > i * hub->ctx_distance, tmp); > WREG32_SOC15_OFFSET(MMHUB, 0, > regMMVM_CONTEXT1_PAGE_TABLE_START_ADDR_LO32, > diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v4_1_0.c > b/drivers/gpu/drm/amd/amdgpu/mmhub_v4_1_0.c > index bef75c4c48d3..c9fb48992a2d 100644 > --- a/drivers/gpu/drm/amd/amdgpu/mmhub_v4_1_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v4_1_0.c > @@ -334,7 +334,7 @@ static void mmhub_v4_1_0_setup_vmid_config(struct > amdgpu_device *adev) > /* Send no-retry XNACK on fault to suppress VM fault storm. */ > tmp = REG_SET_FIELD(tmp, MMVM_CONTEXT1_CNTL, > RETRY_PERMISSION_OR_INVALID_PAGE_FAULT, > - !amdgpu_noretry); > + !adev->gmc.noretry); > WREG32_SOC15_OFFSET(MMHUB, 0, regMMVM_CONTEXT1_CNTL, > i * hub->ctx_distance, tmp); > WREG32_SOC15_OFFSET(MMHUB, 0, > regMMVM_CONTEXT1_PAGE_TABLE_START_ADDR_LO32, > diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v4_2_0.c > b/drivers/gpu/drm/amd/amdgpu/mmhub_v4_2_0.c > index 29f7ed466858..49b7f16a941f 100644 > --- a/drivers/gpu/drm/amd/amdgpu/mmhub_v4_2_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v4_2_0.c > @@ -518,7 +518,7 @@ static void mmhub_v4_2_0_mid_setup_vmid_config(struct > amdgpu_device *adev, > /* Send no-retry XNACK on fault to suppress VM fault > storm. */ > tmp = REG_SET_FIELD(tmp, MMVM_CONTEXT1_CNTL, > > RETRY_PERMISSION_OR_INVALID_PAGE_FAULT, > - !amdgpu_noretry); > + !adev->gmc.noretry); > WREG32_SOC15_OFFSET(MMHUB, GET_INST(MMHUB, j), > regMMVM_CONTEXT1_CNTL, > i * hub->ctx_distance, tmp); > WREG32_SOC15_OFFSET(MMHUB, GET_INST(MMHUB, j), > regMMVM_CONTEXT1_PAGE_TABLE_START_ADDR_LO32,
