There's no need to crash the kernel for these cases.
Signed-off-by: Alex Deucher <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c
index a5ae91af9ef0f..51c384e6cc6ef 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c
@@ -964,8 +964,7 @@ static int gfx_v12_0_gpu_early_init(struct amdgpu_device
*adev)
adev->gfx.config.sc_earlyz_tile_fifo_size = 0x4C0;
break;
default:
- BUG();
- break;
+ return -EINVAL;
}
return 0;
@@ -4455,13 +4454,16 @@ static u64 gfx_v12_0_ring_get_rptr_compute(struct
amdgpu_ring *ring)
static u64 gfx_v12_0_ring_get_wptr_compute(struct amdgpu_ring *ring)
{
+ struct amdgpu_device *adev = ring->adev;
u64 wptr;
/* XXX check if swapping is necessary on BE */
- if (ring->use_doorbell)
+ if (ring->use_doorbell) {
wptr = atomic64_read((atomic64_t *)ring->wptr_cpu_addr);
- else
- BUG();
+ } else {
+ dev_warn(adev->dev, "gfx_v12_0_ring_get_wptr_compute() requires
doorbell!\n");
+ wptr = 0;
+ }
return wptr;
}
@@ -4475,7 +4477,7 @@ static void gfx_v12_0_ring_set_wptr_compute(struct
amdgpu_ring *ring)
ring->wptr);
WDOORBELL64(ring->doorbell_index, ring->wptr);
} else {
- BUG(); /* only DOORBELL method supported on gfx12 now */
+ dev_warn(adev->dev, "gfx_v12_0_ring_set_wptr_compute() requires
doorbell!\n");
}
}
@@ -5048,7 +5050,6 @@ static void gfx_v12_0_handle_priv_fault(struct
amdgpu_device *adev,
}
break;
default:
- BUG();
break;
}
}
--
2.54.0
