AMD General
Get Outlook for Android<https://aka.ms/AAb9ysg> ________________________________ From: Timur Kristóf <[email protected]> Sent: Monday, June 22, 2026 4:39:29 PM To: Koenig, Christian <[email protected]>; Deucher, Alexander <[email protected]>; SHANMUGAM, SRINIVASAN <[email protected]> Cc: [email protected] <[email protected]> Subject: Re: [PATCH] drm/amdgpu: Reduce stack usage in IP block soft reset On 2026. június 22., hétfő 11:10:40 közép-európai nyári idő SHANMUGAM, SRINIVASAN wrote: > > I took another look at the implementation. The temporary array is > currently only used to collect the subset of affected rings and pass > them to the multi-ring reset helpers. > > amdgpu_filter_rings() simply copies matching entries from > adev->rings[] into a temporary array, and the helpers only iterate > over that array. > > From what I can see, adev->rings[] appears to be a stable device ring > list, so it seems possible to eliminate the intermediate array > entirely and have the helpers iterate directly over adev->rings[] > while applying the same ring_type_mask filter. > > Hi Timur, was the temporary array intended to provide snapshot semantics > for the affected rings, or was it mainly introduced for convenience? > > If there is no snapshot requirement, I'll respin the patch by removing > the temporary array altogether. > > Regards, > Srini Hi Srini, I'm sorry for the trouble, I haven't seen this warning. Please give me a moment, I can send a fix later today. Thanks & best regards, Thanks Timur. Sounds good. While looking into the issue, I noticed that the temporary array is only used to collect the affected rings before passing them to the multi-ring reset helpers. It looks like the intermediate array may be avoidable by having the helpers iterate directly over adev->rings[] while applying the same ring_type_mask filter. Thanks, Srini
