I just gave my last missing rb for this series, please push it to amd-staging-drm-next now.
We can discuss with Alex on the call today how to proceed. Regards, Christian. On 6/24/26 19:55, Shahyan Soltani wrote: > This patch series refactors amdgpu.h by moving several structures and their > associated helpers into dedicated or existing header files. This improves > code organization and makes the structure easier to parse. > > v4: > - Added amdgpu_device_wb_init() and amdgpu_device_wb_fini() into > amdgpu_wb.h and amdgpu_wb.c and removed the "_device_" part of the > functions addressing v3's feedback. > - Removed amdgpu_uid patches (v3's patches 2 and 7) for a separate branch > > v3: > - Dropped patch "Move struct amdgpu_sa_manager out of the monolithic header > amdgpu.h into its own dedicated header amdgpu_sa.h" addressing v2's > feedback > - Removed the "_device_" part for amdgpu_wb functions addressing v2's > feedback > - Patches 2 and 7 are unchanged but can be dropped if amdgpu_uid is not > desired to be removed from amdgpu.h > - Removed amdgpu_mqd.h and moved the relevant structs and helpers into > amdgpu_mes.h addressing v2's feedback > - Dropped patch "Move struct amdgpu_init_level and helpers from the > monolithic amdgpu.h > file into a new amdgpu_init_level.h file." addressing v2's feedback > - Dropped patch "Remove #include "amdgpu_init_level.h" from amdgpu.h and add > forward > declaration of struct amdgpu_init_level." > > v2: > - Moved amdgpu_device_wb_get()/free() into new amdgpu_wb.c file and > amdgpu_device_set_uid()/get_uid() into new amdgpu_uid.c file > (addressing v1 review feedback) > - Removed v1 patches 8, 10, and 11 (addressing v1 review feedback) > - Moved the includes of headers amdgpu_uid.h, amdgpu_init_level.h > and amdgpu_video_codecs.h out of amdgpu.h into files where they are > actually used (addressing v1 review feedback) > > Notes from v2: > - Moving the includes out of amdgpu.h into where they are actually used > caused the commits to go into different subsystems like /pm. > - Dropping patches 9, 10, and 11 is advised if this isn't desirable. > > > Shahyan Soltani (6): > drm/amdgpu: move struct amdgpu_wb and helpers into separate files > drm/amdgpu: move struct amdgpu_video_codecs and helpers into header > file > drm/amdgpu: move struct amdgpu_mqd and helpers into header file > drm/amdgpu: move amdgpu_acpi helpers into new header > drm/amdgpu: move amdgpu_allowed_register_entry into > amdgpu_reg_access.h > drm/amdgpu: include amdgpu_video_codecs.h only where needed > > drivers/gpu/drm/amd/amdgpu/Makefile | 3 +- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 267 +----------------- > drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.h | 151 ++++++++++ > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 110 +------- > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 6 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 14 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 16 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_mes.h | 46 +++ > .../gpu/drm/amd/amdgpu/amdgpu_reg_access.h | 8 + > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 18 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.c | 6 +- > .../gpu/drm/amd/amdgpu/amdgpu_video_codecs.h | 47 +++ > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c | 8 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_wb.c | 129 +++++++++ > drivers/gpu/drm/amd/amdgpu/amdgpu_wb.h | 102 +++++++ > drivers/gpu/drm/amd/amdgpu/cik.c | 1 + > drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 8 +- > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 4 +- > drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 4 +- > drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 4 +- > drivers/gpu/drm/amd/amdgpu/gfx_v12_1.c | 4 +- > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 +- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 10 +- > drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 4 +- > drivers/gpu/drm/amd/amdgpu/mes_userqueue.c | 4 +- > drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 6 +- > drivers/gpu/drm/amd/amdgpu/mes_v12_0.c | 6 +- > drivers/gpu/drm/amd/amdgpu/mes_v12_1.c | 6 +- > drivers/gpu/drm/amd/amdgpu/nv.c | 1 + > drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 8 +- > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 8 +- > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 8 +- > drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 8 +- > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 10 +- > drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 10 +- > drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 10 +- > drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c | 10 +- > drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c | 10 +- > drivers/gpu/drm/amd/amdgpu/si.c | 1 + > drivers/gpu/drm/amd/amdgpu/si_dma.c | 8 +- > drivers/gpu/drm/amd/amdgpu/soc15.c | 1 + > drivers/gpu/drm/amd/amdgpu/soc21.c | 1 + > drivers/gpu/drm/amd/amdgpu/soc24.c | 1 + > drivers/gpu/drm/amd/amdgpu/soc_v1_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/vi.c | 1 + > 47 files changed, 614 insertions(+), 481 deletions(-) > create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.h > create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_video_codecs.h > create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_wb.c > create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_wb.h >
