On 7/10/2026 7:29 PM, Srinivasan Shanmugam wrote:
> debugfs is intended for debugging only, and failures to create debugfs
> entries should not affect normal operation.
>
> Remove the check for debugfs_create_dir() in kfd_debugfs_add_process().
> If debugfs entries cannot be created, continue without them instead of
> reporting an unnecessary error.
>
> Fixes: 22ab1bb3994a ("amdkfd: expose pasid of secondary contexts by debugfs")
> Reported-by: Dan Carpenter <[email protected]>
> Cc: Zhu Lingshan <[email protected]>
> Cc: Felix Kuehling <[email protected]>
> Signed-off-by: Srinivasan Shanmugam <[email protected]>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_debugfs.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_debugfs.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_debugfs.c
> index 02673f01b448..7c5bc9c4559a 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_debugfs.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_debugfs.c
> @@ -211,10 +211,6 @@ int kfd_debugfs_add_process(struct kfd_process *p)
> entry->proc_dentry = debugfs_create_dir(name,
>
> primary_entry->proc_dentry);
> }
> - if (IS_ERR_OR_NULL(entry->proc_dentry)) {
> - ret = entry->proc_dentry ? PTR_ERR(entry->proc_dentry) :
> -ENOMEM;
> - goto err_free_entry;
> - }
We need this check because debugfs_create_dir() may fail.
Removing this check leads to entry leaking when fail.
Thanks
Lingshan
>
> list_add(&entry->list, &procs);
> kfd_debugfs_create_pasid_files(p, entry->proc_dentry);
