Hi Guys, I just tried the patch out as positive flow tests (basically make sure umr commands still work before/after) on my gfx12 devel machine and I didn't notice any problems. I've read through the patch and it looks good to me but I'm not super versed in the depths of lockdep. You may add my
Acked-by: Tom St Denis <[email protected]> Tom ________________________________________ From: Mikhail Gavrilov <[email protected]> Sent: Thursday, October 1, 2026 02:27 To: Koenig, Christian Cc: [email protected]; Deucher, Alexander; Prosyak, Vitaly; StDenis, Tom; Mikhail Gavrilov Subject: Re: [PATCH] drm/amdgpu: copy debugfs register data outside the GRBM/SRBM locks On 10/1/26 08:12, Christian König wrote: >> Fixes: 1d0f5838b126 ("drm/amdgpu: Add lockdep annotations for lock ordering >> validation") > > Well that's not really correct since that patch only makes the problem > visible and not introduce it :) Right. The user copies under the locks come from 566281595037 ("drm/amd/amdgpu: Add bank selection for MMIO debugfs (v3)") for amdgpu_regs and 37df9560cd3e ("drm/amd/amdgpu: New debugfs interface for MMIO registers (v5)") for amdgpu_regs2. I'll use those as the Fixes tags in v2, together with your Acked-by, once Tom and Vitaly have had a look. Thanks, Mikhail
