[PATCH] drm/amd/display: Print type if we get wrong ObjectID from bios

[Harry Wentland]

We've seen a bunch of issues where we can't get the connector from vbios
for what we think should be a valid connector id. Print some more info
when this happens.

Change-Id: I96aee657ed4632fbc0ab313671da356dc225c8c4
Signed-off-by: Harry Wentland <harry.wentl...@amd.com>
---

Hi Shawn,

mind trying this patch? It won't fix anything but should give us a bit
more info on why you're getting this invalid connector ObjectId.

Harry

 drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 13 ++++++++++---
 drivers/gpu/drm/amd/display/dc/core/dc_link.c     |  5 +++--
 2 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c 
b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
index aaaebd06d7ee..065f855fd39c 100644
--- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
+++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
@@ -190,6 +190,7 @@ static struct graphics_object_id 
bios_parser_get_connector_id(
        struct bios_parser *bp = BP_FROM_DCB(dcb);
        struct graphics_object_id object_id = dal_graphics_object_id_init(
                0, ENUM_ID_UNKNOWN, OBJECT_TYPE_UNKNOWN);
+       uint16_t id;
 
        uint32_t connector_table_offset = bp->object_info_tbl_offset
                + 
le16_to_cpu(bp->object_info_tbl.v1_1->usConnectorObjectTableOffset);
@@ -197,12 +198,18 @@ static struct graphics_object_id 
bios_parser_get_connector_id(
        ATOM_OBJECT_TABLE *tbl =
                GET_IMAGE(ATOM_OBJECT_TABLE, connector_table_offset);
 
-       if (tbl && tbl->ucNumberOfObjects > i) {
-               const uint16_t id = le16_to_cpu(tbl->asObjects[i].usObjectID);
+       if (!tbl) {
+               dm_error("Can't get connector table from atom bios.\n");
+               return object_id;
+       }
 
-               object_id = object_id_from_bios_object_id(id);
+       if (tbl->ucNumberOfObjects > i) {
+               dm_error("Can't find connector id %d in connector table of size 
%d.\n",
+                        i, tbl->ucNumberOfObjects);
        }
 
+       id = le16_to_cpu(tbl->asObjects[i].usObjectID);
+       object_id = object_id_from_bios_object_id(id);
        return object_id;
 }
 
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c 
b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index 7b0e43c0685c..80fc02671e0e 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -938,8 +938,9 @@ static bool construct(
        link->link_id = bios->funcs->get_connector_id(bios, 
init_params->connector_index);
 
        if (link->link_id.type != OBJECT_TYPE_CONNECTOR) {
-               dm_error("%s: Invalid Connector ObjectID from Adapter Service 
for connector index:%d!\n",
-                               __func__, init_params->connector_index);
+               dm_error("%s: Invalid Connector ObjectID from Adapter Service 
for connector index:%d! type %d expected %d\n",
+                        __func__, init_params->connector_index,
+                        link->link_id.type, OBJECT_TYPE_CONNECTOR);
                goto create_fail;
        }
 
-- 
2.14.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx