From: Mikita Lipski <mikita.lip...@amd.com>

Add more cases for dm_pp clks translator into pp clks so
we can pass the right structures to the powerplay.
Use clks translator instead of massive switch statement.

Change-Id: Ic757734d9e708f81bd72cfe00c55a627a51f8d7a
Signed-off-by: Mikita Lipski <mikita.lip...@amd.com>
Reviewed-by: Tony Cheng <tony.ch...@amd.com>
Acked-by: Harry Wentland <harry.wentl...@amd.com>
---
 .../display/amdgpu_dm/amdgpu_dm_services.c    | 41 ++++++++-----------
 1 file changed, 18 insertions(+), 23 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c
index 025f37f62c4b..a3b8b295aa27 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c
@@ -203,6 +203,21 @@ static enum amd_pp_clock_type dc_to_pp_clock_type(
        case DM_PP_CLOCK_TYPE_MEMORY_CLK:
                amd_pp_clk_type = amd_pp_mem_clock;
                break;
+       case DM_PP_CLOCK_TYPE_DCEFCLK:
+               amd_pp_clk_type  = amd_pp_dcef_clock;
+               break;
+       case DM_PP_CLOCK_TYPE_DCFCLK:
+               amd_pp_clk_type = amd_pp_dcf_clock;
+               break;
+       case DM_PP_CLOCK_TYPE_PIXELCLK:
+               amd_pp_clk_type = amd_pp_pixel_clock;
+               break;
+       case DM_PP_CLOCK_TYPE_FCLK:
+               amd_pp_clk_type = amd_pp_f_clock;
+               break;
+       case DM_PP_CLOCK_TYPE_DISPLAYPHYCLK:
+               amd_pp_clk_type = amd_pp_dpp_clock;
+               break;
        default:
                DRM_ERROR("DM_PPLIB: invalid clock type: %d!\n",
                                dm_pp_clk_type);
@@ -432,32 +447,12 @@ bool dm_pp_apply_clock_for_voltage_request(
        struct amdgpu_device *adev = ctx->driver_context;
        struct pp_display_clock_request pp_clock_request = {0};
        int ret = 0;
-       switch (clock_for_voltage_req->clk_type) {
-       case DM_PP_CLOCK_TYPE_DISPLAY_CLK:
-               pp_clock_request.clock_type = amd_pp_disp_clock;
-               break;
-
-       case DM_PP_CLOCK_TYPE_DCEFCLK:
-               pp_clock_request.clock_type = amd_pp_dcef_clock;
-               break;
 
-       case DM_PP_CLOCK_TYPE_DCFCLK:
-               pp_clock_request.clock_type = amd_pp_dcf_clock;
-               break;
-
-       case DM_PP_CLOCK_TYPE_PIXELCLK:
-               pp_clock_request.clock_type = amd_pp_pixel_clock;
-               break;
-
-       case DM_PP_CLOCK_TYPE_FCLK:
-               pp_clock_request.clock_type = amd_pp_f_clock;
-               break;
+       pp_clock_request.clock_type = 
dc_to_pp_clock_type(clock_for_voltage_req->clk_type);
+       pp_clock_request.clock_freq_in_khz = 
clock_for_voltage_req->clocks_in_khz;
 
-       default:
+       if (!pp_clock_request.clock_type)
                return false;
-       }
-
-       pp_clock_request.clock_freq_in_khz = 
clock_for_voltage_req->clocks_in_khz;
 
        if (adev->powerplay.pp_funcs->display_clock_voltage_request)
                ret = adev->powerplay.pp_funcs->display_clock_voltage_request(
-- 
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to