Reviewed-by: Rex Zhu<re...@amd.com<mailto:re...@amd.com>>


Best Regards
Rex



________________________________
From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Alex Deucher 
<alexdeuc...@gmail.com>
Sent: Thursday, July 19, 2018 5:08 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH] drm/amdgpu/powerplay: use irq source defines for smu7 sources

Use the newly added irq source defines rather than magic numbers
for smu7 thermal interrupts.

Signed-off-by: Alex Deucher <alexander.deuc...@amd.com>
---
 drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c 
b/drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c
index 8eea49e4c74d..2aab1b475945 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c
@@ -27,6 +27,7 @@
 #include "atom.h"
 #include "ivsrcid/thm/irqsrcs_thm_9_0.h"
 #include "ivsrcid/smuio/irqsrcs_smuio_9_0.h"
+#include "ivsrcid/ivsrcid_vislands30.h"

 uint8_t convert_to_vid(uint16_t vddc)
 {
@@ -545,17 +546,17 @@ int phm_irq_process(struct amdgpu_device *adev,
         uint32_t src_id = entry->src_id;

         if (client_id == AMDGPU_IH_CLIENTID_LEGACY) {
-               if (src_id == 230)
+               if (src_id == VISLANDS30_IV_SRCID_CG_TSS_THERMAL_LOW_TO_HIGH)
                         pr_warn("GPU over temperature range detected on PCIe 
%d:%d.%d!\n",
                                                 PCI_BUS_NUM(adev->pdev->devfn),
                                                 PCI_SLOT(adev->pdev->devfn),
                                                 PCI_FUNC(adev->pdev->devfn));
-               else if (src_id == 231)
+               else if (src_id == 
VISLANDS30_IV_SRCID_CG_TSS_THERMAL_HIGH_TO_LOW)
                         pr_warn("GPU under temperature range detected on PCIe 
%d:%d.%d!\n",
                                         PCI_BUS_NUM(adev->pdev->devfn),
                                         PCI_SLOT(adev->pdev->devfn),
                                         PCI_FUNC(adev->pdev->devfn));
-               else if (src_id == 83)
+               else if (src_id == VISLANDS30_IV_SRCID_GPIO_19)
                         pr_warn("GPU Critical Temperature Fault detected on 
PCIe %d:%d.%d!\n",
                                         PCI_BUS_NUM(adev->pdev->devfn),
                                         PCI_SLOT(adev->pdev->devfn),
--
2.13.6

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
amd-gfx Info Page - 
freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx>
lists.freedesktop.org
Subscribing to amd-gfx: Subscribe to amd-gfx by filling out the following form. 
Use of all freedesktop.org lists is subject to our Code of Conduct.


_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to