Hi Wentao,
We need to check psp firmware version here instead of to change
psp_ring_destroy to psp_ring_stop.
Best wishes
Emily Deng
>-----Original Message-----
>From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> On Behalf Of Yu,
>Xiangliang
>Sent: Tuesday, December 18, 2018 3:58 PM
>To: Lou, Wentao <wentao....@amd.com>; amd-gfx@lists.freedesktop.org
>Subject: RE: [PATCH] drm/amdgpu: psp_ring_destroy cause psp-
>>km_ring.ring_mem NULL
>
>Reviewed-by: Xiangliang Yu <xiangliang...@amd.com>
>
>
>
>-----Original Message-----
>From: Lou, Wentao <wentao....@amd.com>
>Sent: Tuesday, December 18, 2018 3:52 PM
>To: amd-gfx@lists.freedesktop.org
>Cc: Lou, Wentao <wentao....@amd.com>
>Subject: [PATCH] drm/amdgpu: psp_ring_destroy cause psp->km_ring.ring_mem
>NULL
>
>psp_ring_destroy inside psp_load_fw cause psp->km_ring.ring_mem NULL.
>Call Trace occurred when psp_cmd_submit.
>should be psp_ring_stop instead.
>
>Change-Id: Ib332004b3b9edc9e002adc532b2d45cdad929b05
>Signed-off-by: Wentao Lou <wentao....@amd.com>
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
>b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
>index 7f5ce37..8189a90 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
>@@ -547,7 +547,7 @@ static int psp_load_fw(struct amdgpu_device *adev)
> struct psp_context *psp = &adev->psp;
>
> if (amdgpu_sriov_vf(adev) && adev->in_gpu_reset) {
>- psp_ring_destroy(psp, PSP_RING_TYPE__KM);
>+ psp_ring_stop(psp, PSP_RING_TYPE__KM); /* should not destroy
>ring, only stop */
> goto skip_memalloc;
> }
>
>--
>2.7.4
>
>_______________________________________________
>amd-gfx mailing list
>amd-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
