> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Thursday, March 21, 2019 2:28 PM
> To: Deucher, Alexander <alexander.deuc...@amd.com>; Wang, Kevin(Yang)
> <kevin1.w...@amd.com>
> Cc: Koenig, Christian <christian.koe...@amd.com>; Zhou, David(ChunMing)
> <david1.z...@amd.com>; David Airlie <airl...@linux.ie>; Daniel Vetter
> <dan...@ffwll.ch>; Huang, Ray <ray.hu...@amd.com>; Gao, Likun
> <likun....@amd.com>; Gui, Jack <jack....@amd.com>; amd-
> g...@lists.freedesktop.org; kernel-janit...@vger.kernel.org
> Subject: [PATCH] drm/amd/powerplay: Fix double unlock bug in
> smu_sys_set_pp_table()
>
> We already unlocked a few lines earlier so this code unlocks twice on the
> success path.
>
> Fixes: 5809d7420f97 ("drm/amd/powerplay: implement sysfs of pp_table for
> smu11 (v2)")
> Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
Nice catch! Thanks, Dan.
Kevin, could you please verify this patch.
Reviewed-by: Huang Rui <ray.hu...@amd.com>
> ---
> I'm not sure what this bug looks like at runtime, but it's slightly weird
> that no
> one noticed. This is from static analysis and I haven't tested it myself.
>
> drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> index 00b7c885772b..7e8c74da6a74 100644
> --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> @@ -187,6 +187,8 @@ int smu_sys_set_pp_table(struct smu_context *smu,
> void *buf, size_t size)
> if (ret)
> pr_info("smu reset failed, ret = %d\n", ret);
>
> + return ret;
> +
> failed:
> mutex_unlock(&smu->mutex);
> return ret;
> --
> 2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
