On 2019-03-22 9:59 a.m., Nicholas Kazlauskas wrote: > The brace initialization used here generates warnings on some > compilers. For example, on GCC 4.9: > > [...] In function ‘dm_determine_update_type_for_commit’: > [...] error: missing braces around initializer [-Werror=missing-braces] > struct dc_stream_update stream_update = { 0 }; > ^ > > Use memset to make this more portable. > > v2: Specify the compiler / diagnostic in the commit message (Paul) > > Cc: Sun peng Li <sunpeng...@amd.com> > Cc: Harry Wentland <harry.wentl...@amd.com> > Signed-off-by: Nicholas Kazlauskas <nicholas.kazlaus...@amd.com>
Reviewed-by: Leo Li <sunpeng...@amd.com> > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > index 5b7a85e28fab..9cdd52edfc3d 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -5982,7 +5982,9 @@ dm_determine_update_type_for_commit(struct dc *dc, > } > > for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, > new_crtc_state, i) { > - struct dc_stream_update stream_update = { 0 }; > + struct dc_stream_update stream_update; > + > + memset(&stream_update, 0, sizeof(stream_update)); > > new_dm_crtc_state = to_dm_crtc_state(new_crtc_state); > old_dm_crtc_state = to_dm_crtc_state(old_crtc_state); > _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx