[PATCH 17/26] drm/amd/display: Fix type of pp_smu_wm_set_range struct

[sunpeng.li]

From: Eric Yang <eric.ya...@amd.com>

[why]
Value read from SMU is 16 bits, not 32.

[How]
Fix type, and add wm_type enum in preparation for future interfaces.

Signed-off-by: Eric Yang <eric.ya...@amd.com>
Reviewed-by: Tony Cheng <tony.ch...@amd.com>
Acked-by: Leo Li <sunpeng...@amd.com>
---
 drivers/gpu/drm/amd/display/dc/dm_pp_smu.h | 31 +++++++++++++++++++++++++-----
 1 file changed, 26 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dm_pp_smu.h 
b/drivers/gpu/drm/amd/display/dc/dm_pp_smu.h
index 9f7ebf6..471f3df 100644
--- a/drivers/gpu/drm/amd/display/dc/dm_pp_smu.h
+++ b/drivers/gpu/drm/amd/display/dc/dm_pp_smu.h
@@ -41,6 +41,7 @@ enum pp_smu_ver {
         */
        PP_SMU_UNSUPPORTED,
        PP_SMU_VER_RV,
+
        PP_SMU_VER_MAX
 };
 
@@ -56,12 +57,31 @@ struct pp_smu {
        const void *dm;
 };
 
+enum pp_smu_status {
+       PP_SMU_RESULT_UNDEFINED = 0,
+       PP_SMU_RESULT_OK = 1,
+       PP_SMU_RESULT_FAIL,
+       PP_SMU_RESULT_UNSUPPORTED
+};
+
+
+#define PP_SMU_WM_SET_RANGE_CLK_UNCONSTRAINED_MIN 0x0
+#define PP_SMU_WM_SET_RANGE_CLK_UNCONSTRAINED_MAX 0xFFFF
+
+enum wm_type {
+       WM_TYPE_PSTATE_CHG = 0,
+       WM_TYPE_RETRAINING = 1,
+};
+
+/* This structure is a copy of WatermarkRowGeneric_t defined by 
smuxx_driver_if.h*/
 struct pp_smu_wm_set_range {
-       unsigned int wm_inst;
-       uint32_t min_fill_clk_mhz;
-       uint32_t max_fill_clk_mhz;
-       uint32_t min_drain_clk_mhz;
-       uint32_t max_drain_clk_mhz;
+       uint16_t min_fill_clk_mhz;
+       uint16_t max_fill_clk_mhz;
+       uint16_t min_drain_clk_mhz;
+       uint16_t max_drain_clk_mhz;
+
+       uint8_t wm_inst;
+       uint8_t wm_type;
 };
 
 #define MAX_WATERMARK_SETS 4
@@ -122,6 +142,7 @@ struct pp_smu_funcs {
        struct pp_smu ctx;
        union {
                struct pp_smu_funcs_rv rv_funcs;
+
        };
 };
 
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx