No problem. Thanks for your reviewing. Best wishes Emily Deng From: Christian König <ckoenig.leichtzumer...@gmail.com> Sent: Wednesday, May 29, 2019 3:54 PM To: Deng, Emily <emily.d...@amd.com>; amd-gfx@lists.freedesktop.org; Koenig, Christian <christian.koe...@amd.com>; Quan, Evan <evan.q...@amd.com> Subject: Re: [PATCH] drm/amdgpu:Fix the unpin warning about csb buffer
Sorry for the delay, your patch simply got stuck in the daily wave of mails. Reviewed-by: Christian König <christian.koe...@amd.com><mailto:christian.koe...@amd.com> Regards, Christian. Am 29.05.19 um 05:07 schrieb Deng, Emily: Hi Christian, I have reverted the before change as your suggestion, and sent this new patch, could you help to review this? Best wishes Emily Deng -----Original Message----- From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org><mailto:amd-gfx-boun...@lists.freedesktop.org> On Behalf Of Deng, Emily Sent: Wednesday, May 29, 2019 10:52 AM To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Subject: RE: [PATCH] drm/amdgpu:Fix the unpin warning about csb buffer Ping...... Best wishes Emily Deng -----Original Message----- From: Deng, Emily <emily.d...@amd.com><mailto:emily.d...@amd.com> Sent: Tuesday, May 28, 2019 6:14 PM To: Deng, Emily <emily.d...@amd.com><mailto:emily.d...@amd.com>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Subject: RE: [PATCH] drm/amdgpu:Fix the unpin warning about csb buffer Ping ...... Best wishes Emily Deng -----Original Message----- From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org><mailto:amd-gfx-boun...@lists.freedesktop.org> On Behalf Of Emily Deng Sent: Tuesday, May 28, 2019 4:06 PM To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Cc: Deng, Emily <emily.d...@amd.com><mailto:emily.d...@amd.com> Subject: [PATCH] drm/amdgpu:Fix the unpin warning about csb buffer As it will destroy clear_state_obj, and also will unpin it in the gfx_v9_0_sw_fini, so don't need to call amdgpu_bo_free_kernel in gfx_v9_0_sw_fini, or it will have unpin warning. Signed-off-by: Emily Deng <emily.d...@amd.com><mailto:emily.d...@amd.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index c763733..cc5a382 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c @@ -1794,9 +1794,7 @@ static int gfx_v9_0_sw_fini(void *handle) gfx_v9_0_mec_fini(adev); gfx_v9_0_ngg_fini(adev); - amdgpu_bo_free_kernel(&adev->gfx.rlc.clear_state_obj, - &adev->gfx.rlc.clear_state_gpu_addr, - (void **)&adev->gfx.rlc.cs_ptr); + amdgpu_bo_unref(&adev->gfx.rlc.clear_state_obj); if (adev->asic_type == CHIP_RAVEN) { amdgpu_bo_free_kernel(&adev->gfx.rlc.cp_table_obj, &adev->gfx.rlc.cp_table_gpu_addr, -- 2.7.4 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
