Sounds good. Thanks for confirming. Alex ________________________________ From: Quan, Evan Sent: Monday, June 24, 2019 3:50 AM To: Deucher, Alexander; Russell, Kent; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amd/powerplay: no memory activity support on Vega10
Smu7 ASICs support memory activity report also by reading register directly. But for Vega10, there is not any SMC message and metrics table for that. And there is no information about any register related with that. So, we cannot get the memory activity on Vega10. It’s not a regression. Regards, Evan From: Deucher, Alexander <alexander.deuc...@amd.com> Sent: Friday, June 21, 2019 10:19 PM To: Russell, Kent <kent.russ...@amd.com>; Quan, Evan <evan.q...@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/powerplay: no memory activity support on Vega10 Maybe it's dependent on the SMU firwmare version? Alex ________________________________ From: Russell, Kent Sent: Friday, June 21, 2019 9:54 AM To: Deucher, Alexander; Quan, Evan; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Subject: RE: [PATCH] drm/amd/powerplay: no memory activity support on Vega10 It works on my Fiji card. Maybe Vega10 functionality is just broken in this regard? Kent From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org<mailto:amd-gfx-boun...@lists.freedesktop.org>> On Behalf Of Deucher, Alexander Sent: Friday, June 21, 2019 9:42 AM To: Quan, Evan <evan.q...@amd.com<mailto:evan.q...@amd.com>>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Subject: Re: [PATCH] drm/amd/powerplay: no memory activity support on Vega10 Is this supported on smu7 parts as well? Might be better to just enable it on the specific asics that support it. I think it might just be vega20. Alex ________________________________ From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org<mailto:amd-gfx-boun...@lists.freedesktop.org>> on behalf of Evan Quan <evan.q...@amd.com<mailto:evan.q...@amd.com>> Sent: Thursday, June 20, 2019 10:07 PM To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: no memory activity support on Vega10 Make mem_busy_percent sysfs interface invisible on Vega10. Change-Id: Ie39c3217b497a110b0b16e1b08033029bdcf2fc8 Signed-off-by: Evan Quan <evan.q...@amd.com<mailto:evan.q...@amd.com>> --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c index 7ed84736ccc9..bcf6e089dc2e 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c @@ -2945,7 +2945,8 @@ int amdgpu_pm_sysfs_init(struct amdgpu_device *adev) return ret; } /* APU does not have its own dedicated memory */ - if (!(adev->flags & AMD_IS_APU)) { + if (!(adev->flags & AMD_IS_APU) && + (adev->asic_type != CHIP_VEGA10)) { ret = device_create_file(adev->dev, &dev_attr_mem_busy_percent); if (ret) { @@ -3025,7 +3026,8 @@ void amdgpu_pm_sysfs_fini(struct amdgpu_device *adev) device_remove_file(adev->dev, &dev_attr_pp_od_clk_voltage); device_remove_file(adev->dev, &dev_attr_gpu_busy_percent); - if (!(adev->flags & AMD_IS_APU)) + if (!(adev->flags & AMD_IS_APU) && + (adev->asic_type != CHIP_VEGA10)) device_remove_file(adev->dev, &dev_attr_mem_busy_percent); if (!(adev->flags & AMD_IS_APU)) device_remove_file(adev->dev, &dev_attr_pcie_bw); -- 2.21.0 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
