From: Colin Ian King <colin.k...@canonical.com>

Currently adev->mes.ucode_fw_version is being assigned twice with
different values. This looks like a cut-n-paste error and instead
the second assignment should be adev->mes.data_fw_version. Fix
this.

Addresses-Coverity: ("Unused value")
Fixes: 298d05460cc4 ("drm/amdgpu/mes10.1: load mes firmware file to CPU buffer")
Signed-off-by: Colin Ian King <colin.k...@canonical.com>
---
 drivers/gpu/drm/amd/amdgpu/mes_v10_1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v10_1.c 
b/drivers/gpu/drm/amd/amdgpu/mes_v10_1.c
index 29fab7984855..2a27f0b30bb5 100644
--- a/drivers/gpu/drm/amd/amdgpu/mes_v10_1.c
+++ b/drivers/gpu/drm/amd/amdgpu/mes_v10_1.c
@@ -91,7 +91,7 @@ static int mes_v10_1_init_microcode(struct amdgpu_device 
*adev)
 
        mes_hdr = (const struct mes_firmware_header_v1_0 *)adev->mes.fw->data;
        adev->mes.ucode_fw_version = le32_to_cpu(mes_hdr->mes_ucode_version);
-       adev->mes.ucode_fw_version =
+       adev->mes.data_fw_version =
                le32_to_cpu(mes_hdr->mes_ucode_data_version);
        adev->mes.uc_start_addr =
                le32_to_cpu(mes_hdr->mes_uc_start_addr_lo) |
-- 
2.20.1

Reply via email to