From: Wyatt Wood <wyatt.w...@amd.com>

[Why]
A recent bug showed that logging would be useful in debugging
various gamma issues.

[How]
Add logging in dc.
Fix formatting for easier graphing.

Signed-off-by: Wyatt Wood <wyatt.w...@amd.com>
Reviewed-by: Anthony Koo <anthony....@amd.com>
Acked-by: Bhawanpreet Lakha <bhawanpreet.la...@amd.com>
---
 .../drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c    | 12 ++++++------
 .../gpu/drm/amd/display/modules/color/color_gamma.c  |  4 ++--
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c 
b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
index 004675db686d..0e7d929c254c 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
@@ -1451,15 +1451,15 @@ static void log_tf(struct dc_context *ctx,
        DC_LOG_ALL_TF_CHANNELS("Logging all channels...");
 
        for (i = 0; i < hw_points_num; i++) {
-               DC_LOG_GAMMA("R %d %llu\n", i, tf->tf_pts.red[i].value);
-               DC_LOG_ALL_TF_CHANNELS("G %d, %llu\n", i, 
tf->tf_pts.green[i].value);
-               DC_LOG_ALL_TF_CHANNELS("B %d, %llu\n", i, 
tf->tf_pts.blue[i].value);
+               DC_LOG_GAMMA("R\t%d\t%llu\n", i, tf->tf_pts.red[i].value);
+               DC_LOG_ALL_TF_CHANNELS("G\t%d\t%llu\n", i, 
tf->tf_pts.green[i].value);
+               DC_LOG_ALL_TF_CHANNELS("B\t%d\t%llu\n", i, 
tf->tf_pts.blue[i].value);
        }
 
        for (i = hw_points_num; i < MAX_NUM_HW_POINTS; i++) {
-               DC_LOG_ALL_GAMMA("R %d %llu\n", i, tf->tf_pts.red[i].value);
-               DC_LOG_ALL_TF_CHANNELS("G %d %llu\n", i, 
tf->tf_pts.green[i].value);
-               DC_LOG_ALL_TF_CHANNELS("B %d %llu\n", i, 
tf->tf_pts.blue[i].value);
+               DC_LOG_ALL_GAMMA("R\t%d\t%llu\n", i, tf->tf_pts.red[i].value);
+               DC_LOG_ALL_TF_CHANNELS("G\t%d\t%llu\n", i, 
tf->tf_pts.green[i].value);
+               DC_LOG_ALL_TF_CHANNELS("B\t%d\t%llu\n", i, 
tf->tf_pts.blue[i].value);
        }
 }
 
diff --git a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c 
b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c
index 8f78ea226dae..19475cf5ab72 100644
--- a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c
+++ b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c
@@ -99,10 +99,10 @@ void log_x_points_distribution(struct dal_logger *logger)
        int i = 0;
 
        if (logger != NULL) {
-               LOG_GAMMA_WRITE("]Log X Distribution\n");
+               LOG_GAMMA_WRITE("Log X Distribution\n");
 
                for (i = 0; i < MAX_HW_POINTS; i++)
-                       LOG_GAMMA_WRITE("]%llu\n", coordinates_x[i].x.value);
+                       LOG_GAMMA_WRITE("%llu\n", coordinates_x[i].x.value);
        }
 }
 
-- 
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to