Got it, I will make a v2 patch.
Thanks.

-----Original Message-----
From: Zhang, Hawking 
Sent: Tuesday, August 20, 2019 2:52 PM
To: Feng, Kenneth <kenneth.f...@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Feng, Kenneth <kenneth.f...@amd.com>
Subject: RE: [PATCH] drm/amd/powerplay: disable MMHUB PG on navi10/14

Hi Kenneth,

We should control PG feature on/off from nv_common_early_init by setting 
initial value of pg_flag, instead of hard-code it from SMU side.

Regards,
Hawking
-----Original Message-----
From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> On Behalf Of Kenneth Feng
Sent: 2019年8月20日 14:34
To: amd-gfx@lists.freedesktop.org
Cc: Feng, Kenneth <kenneth.f...@amd.com>
Subject: [PATCH] drm/amd/powerplay: disable MMHUB PG on navi10/14

Disable MMHUB PG on navi10 and navi14 according to the production requirement.

Signed-off-by: Kenneth Feng <kenneth.f...@amd.com>
---
 drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c 
b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
index 920156e..8b306d1 100644
--- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
+++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
@@ -361,9 +361,6 @@ navi10_get_allowed_feature_mask(struct smu_context *smu,
                *(uint64_t *)feature_mask &= 
~FEATURE_MASK(FEATURE_FW_DSTATE_BIT);
        }
 
-       if (smu->adev->pg_flags & AMD_PG_SUPPORT_MMHUB)
-               *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_MMHUB_PG_BIT);
-
        if (smu->adev->pg_flags & AMD_PG_SUPPORT_ATHUB)
                *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_ATHUB_PG_BIT);
 
--
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to