There are two cases of reserve error should be ignored:
1) a ras bad page has been allocated (used by someone);
2) a ras bad page has been reserved (duplicate error injection for one page);

DRM_ERROR is unnecessary for the failure of bad page reserve

Signed-off-by: Tao Zhou <tao.zh...@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index dc5f94e6118b..0425b74e1a8b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
@@ -1478,9 +1478,15 @@ int amdgpu_ras_reserve_bad_pages(struct amdgpu_device 
*adev)
        for (i = data->last_reserved; i < data->count; i++) {
                bp = data->bps[i].retired_page;
 
+               /*
+                * There are two cases of reserve error should be ignored:
+                * 1) a ras bad page has been allocated (used by someone);
+                * 2) a ras bad page has been reserved (duplicate error 
injection
+                * for one page);
+                */
                if (amdgpu_ras_reserve_vram(adev, bp << PAGE_SHIFT,
                                        PAGE_SIZE, &bo))
-                       DRM_ERROR("RAS ERROR: reserve vram %llx fail\n", bp);
+                       DRM_WARN("RAS WARN: reserve vram for retired page %llx 
fail\n", bp);
 
                data->bps_bo[i] = bo;
                data->last_reserved = i + 1;
-- 
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to