I know, that's the usual chicken and egg problem with updating libdrm.
But we should update the file with the kernel version and not pick all changes
line by line.
Christian.
Am 15.11.2019 15:49 schrieb "Deucher, Alexander" <alexander.deuc...@amd.com>:
We can't land the kernel side until we have real userspace (e.g., Mesa) that
uses the TMZ interfaces. The unit tests are not enough.
Alex
________________________________
From: Christian König <ckoenig.leichtzumer...@gmail.com>
Sent: Friday, November 15, 2019 7:56 AM
To: Liu, Aaron <aaron....@amd.com>; amd-gfx@lists.freedesktop.org
<amd-gfx@lists.freedesktop.org>
Cc: Olsak, Marek <marek.ol...@amd.com>; Huang, Ray <ray.hu...@amd.com>; Tuikov,
Luben <luben.tui...@amd.com>; Deucher, Alexander <alexander.deuc...@amd.com>;
Liu, Leo <leo....@amd.com>; Koenig, Christian <christian.koe...@amd.com>
Subject: Re: [PATCH 01/12] amdgpu: add UAPI for creating encrypted buffers
Am 15.11.19 um 04:34 schrieb Aaron Liu:
> From: Huang Rui <ray.hu...@amd.com>
>
> To align the kernel uapi change from Alex:
>
> "Add a flag to the GEM_CREATE ioctl to create encrypted buffers. Buffers with
> this flag set will be created with the TMZ bit set in the PTEs or engines
> accessing them. This is required in order to properly access the data from the
> engines."
>
> We will use GEM_CREATE_ENCRYPTED flag for secure buffer allocation.
>
> Signed-off-by: Huang Rui <ray.hu...@amd.com>
> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com>
Please read up on how amdpu_drm.h is updated. The change must first land
upstream and then the file is synced up somehow semi-automatic.
Christian.
> ---
> include/drm/amdgpu_drm.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h
> index 5c28aa7..1a95e37 100644
> --- a/include/drm/amdgpu_drm.h
> +++ b/include/drm/amdgpu_drm.h
> @@ -141,6 +141,11 @@ extern "C" {
> * releasing the memory
> */
> #define AMDGPU_GEM_CREATE_VRAM_WIPE_ON_RELEASE (1 << 9)
> +/* Flag that BO will be encrypted and that the TMZ bit should be
> + * set in the PTEs when mapping this buffer via GPUVM or
> + * accessing it with various hw blocks
> + */
> +#define AMDGPU_GEM_CREATE_ENCRYPTED (1 << 10)
>
> /* Hybrid specific */
> /* Flag that the memory allocation should be from top of domain */
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
