RE: [PATCH] drm/amd/amdgpu: set error query ready after all IPs late init

[Zhang, Hawking]

[AMD Public Use]

        if (adev->in_suspend || adev->in_gpu_reset) {
-               amdgpu_ras_set_error_query_ready(adev, true);
                return 0;
        }
Please also remove the "{}". With that fixed, the patch is

Reviewed-by: Hawking Zhang <hawking.zh...@amd.com>

Regards,
Hawking

-----Original Message-----
From: Chen, Guchun <guchun.c...@amd.com> 
Sent: Wednesday, April 22, 2020 12:48
To: Li, Dennis <dennis...@amd.com>; amd-gfx@lists.freedesktop.org; Deucher, 
Alexander <alexander.deuc...@amd.com>; Zhou1, Tao <tao.zh...@amd.com>; Zhang, 
Hawking <hawking.zh...@amd.com>
Cc: Li, Dennis <dennis...@amd.com>
Subject: RE: [PATCH] drm/amd/amdgpu: set error query ready after all IPs late 
init

[AMD Public Use]

Need to modify prefix of commit tile to 'drm/amdgpu'.

With that fixed, the patch is: Reviewed-by: Guchun Chen <guchun.c...@amd.com>

Regards,
Guchun

-----Original Message-----
From: Dennis Li <dennis...@amd.com> 
Sent: Wednesday, April 22, 2020 12:31 PM
To: amd-gfx@lists.freedesktop.org; Deucher, Alexander 
<alexander.deuc...@amd.com>; Zhou1, Tao <tao.zh...@amd.com>; Zhang, Hawking 
<hawking.zh...@amd.com>; Chen, Guchun <guchun.c...@amd.com>
Cc: Li, Dennis <dennis...@amd.com>
Subject: [PATCH] drm/amd/amdgpu: set error query ready after all IPs late init

If set error query ready in amdgpu_ras_late_init, which will cause some IP 
blocks aren't initialized, but their error query is ready.

Change-Id: I5087527261cb1b462afd82ad7592cf1ef73b15bd
Signed-off-by: Dennis Li <dennis...@amd.com>

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
old mode 100644
new mode 100755
index 423eed223aa5..e37e0982cd46
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2218,6 +2218,8 @@ static int amdgpu_device_ip_late_init(struct 
amdgpu_device *adev)
                adev->ip_blocks[i].status.late_initialized = true;
        }
 
+       amdgpu_ras_set_error_query_ready(adev, true);
+
        amdgpu_device_set_cg_state(adev, AMD_CG_STATE_GATE);
        amdgpu_device_set_pg_state(adev, AMD_PG_STATE_GATE);
 
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index 68b82f7b0b80..060866d372a4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
@@ -1922,7 +1922,6 @@ int amdgpu_ras_late_init(struct amdgpu_device *adev,
 
        /* in resume phase, no need to create ras fs node */
        if (adev->in_suspend || adev->in_gpu_reset) {
-               amdgpu_ras_set_error_query_ready(adev, true);
                return 0;
        }
 
@@ -1936,8 +1935,6 @@ int amdgpu_ras_late_init(struct amdgpu_device *adev,
        if (r)
                goto sysfs;
 
-       amdgpu_ras_set_error_query_ready(adev, true);
-
        return 0;
 cleanup:
        amdgpu_ras_sysfs_remove(adev, ras_block);
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx