[AMD Public Use] Shouldn't all of this code be moved later anyway to make sure the SMU is up and running already?
Alex ________________________________ From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Kent Russell <kent.russ...@amd.com> Sent: Thursday, May 7, 2020 9:53 AM To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org> Cc: Russell, Kent <kent.russ...@amd.com> Subject: [PATCH] drm/amdgpu: Don't report unique_id for Arcturus This isn't supported in the SMU yet, so just break early. This can be reverted once the SMU supports the feature Signed-off-by: Kent Russell <kent.russ...@amd.com> Change-Id: I09945613aa7400afdf3f9d5dc0ffb636ee2896f7 --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c index f55f9b371bf2..cb90825aacf1 100644 --- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c @@ -317,6 +317,11 @@ static int arcturus_tables_init(struct smu_context *smu, struct smu_table *table smu_table->metrics_time = 0; if (smu->adev->asic_type == CHIP_ARCTURUS) { + /* TODO: SMU doesn't currently support this. Return + * early and remove this once SMU supports it + */ + return 0; + /* Get the SN to turn into a Unique ID */ smu_send_smc_msg(smu, SMU_MSG_ReadSerialNumTop32, &top32); -- 2.17.1 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Calexander.deucher%40amd.com%7C2081bb617dd14d81e7a108d7f28e1f8f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637244564588764106&sdata=GevSmW%2Fgzq862kdiJwcbGbCMHfboIGx77zfA%2FOuwhW8%3D&reserved=0
_______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx