[AMD Public Use]
Thanks Tao. I will address that when pushing.
Regards,
Guchun
-----Original Message-----
From: Zhou1, Tao <tao.zh...@amd.com>
Sent: Friday, May 22, 2020 4:51 PM
To: Chen, Guchun <guchun.c...@amd.com>; amd-gfx@lists.freedesktop.org; Zhang,
Hawking <hawking.zh...@amd.com>; Clements, John <john.cleme...@amd.com>; Li,
Dennis <dennis...@amd.com>
Subject: RE: [PATCH] drm/amdgpu: print warning when input address is invalid
[AMD Public Use]
OK, but I still suggest adding "RAS" in the print to indicate its module, with
this addressed the patch is:
Reviewed-by: Tao Zhou <tao.zh...@amd.com>
> -----Original Message-----
> From: Chen, Guchun <guchun.c...@amd.com>
> Sent: 2020年5月22日 16:31
> To: Zhou1, Tao <tao.zh...@amd.com>; amd-gfx@lists.freedesktop.org;
> Zhang, Hawking <hawking.zh...@amd.com>; Clements, John
> <john.cleme...@amd.com>; Li, Dennis <dennis...@amd.com>
> Subject: RE: [PATCH] drm/amdgpu: print warning when input address is
> invalid
>
> [AMD Public Use]
>
> Hi Tao,
>
> Please see my response inline.
>
> Regards,
> Guchun
>
> -----Original Message-----
> From: Zhou1, Tao <tao.zh...@amd.com>
> Sent: Friday, May 22, 2020 4:11 PM
> To: Chen, Guchun <guchun.c...@amd.com>; amd-
> g...@lists.freedesktop.org; Zhang, Hawking <hawking.zh...@amd.com>;
> Clements, John <john.cleme...@amd.com>; Li, Dennis <dennis...@amd.com>
> Subject: RE: [PATCH] drm/amdgpu: print warning when input address is
> invalid
>
> [AMD Official Use Only - Internal Distribution Only]
>
>
>
> > -----Original Message-----
> > From: Chen, Guchun <guchun.c...@amd.com>
> > Sent: 2020年5月22日 15:53
> > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking
> > <hawking.zh...@amd.com>; Zhou1, Tao <tao.zh...@amd.com>;
> Clements,
> > John <john.cleme...@amd.com>; Li, Dennis <dennis...@amd.com>
> > Cc: Chen, Guchun <guchun.c...@amd.com>
> > Subject: [PATCH] drm/amdgpu: print warning when input address is
> > invalid
> >
> > This will assist debug.
> >
> > Signed-off-by: Guchun Chen <guchun.c...@amd.com>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> > index 6e911ca97038..5c73f444eaef 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> > @@ -318,6 +318,8 @@ static ssize_t
> > amdgpu_ras_debugfs_ctrl_write(struct
> > file *f, const char __user *
> > case 2:
> > if ((data.inject.address >= adev->gmc.mc_vram_size) ||
> > (data.inject.address >= RAS_UMC_INJECT_ADDR_LIMIT)) {
> > + dev_warn(adev->dev, "Input address 0x%llx is
> > invalid.",
> > + data.inject.address);
>
> [Tao] How about this way:
> dev_warn(adev->dev, "RAS injection address 0x%llx exceeds limit 0x%llx.",
> data.inject.address,
> RAS_UMC_INJECT_ADDR_LIMIT); [Guchun]There are two cases for invalid
> input address, one is limited by board vram size, and one is by
> RAS_UMC_INJECT_ADDR_LIMIT.
> So it's not necessary to distinguish here, just print warning to let
> user knows the input address is not correct, and this error injection is
> blocked.
>
> > ret = -EINVAL;
> > break;
> > }
> > --
> > 2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
