Your Signed-of-by line is missing and a one liner commit message would be nice to have. Something like "Cleaning up radeon leftovers."

With that fixed the patch is Reviewed-by: Christian König <christian.koe...@amd.com>.

Am 18.06.20 um 00:00 schrieb Sonny Jiang:
---
  drivers/gpu/drm/amd/amdgpu/sid.h | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/sid.h b/drivers/gpu/drm/amd/amdgpu/sid.h
index 7cf12adb3915..75b5d441b628 100644
--- a/drivers/gpu/drm/amd/amdgpu/sid.h
+++ b/drivers/gpu/drm/amd/amdgpu/sid.h
@@ -1646,9 +1646,10 @@
  /*
   * PM4
   */
-#define PACKET0(reg, n)        ((RADEON_PACKET_TYPE0 << 30) |                  
  \
-                        (((reg) >> 2) & 0xFFFF) |                    \
-                        ((n) & 0x3FFF) << 16)
+#define PACKET_TYPE0    0
+#define PACKET0(reg, n) ((PACKET_TYPE0 << 30) |                          \
+                         ((reg) & 0xFFFF) |                                \
+                         ((n) & 0x3FFF) << 16)
  #define CP_PACKET2                    0x80000000
  #define               PACKET2_PAD_SHIFT               0
  #define               PACKET2_PAD_MASK                (0x3fffffff << 0)

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to