[AMD Public Use]
Also, general nit, per kernel coding style, braces should be on the same line
as the if or else, E.g.,
} else {
Alex
________________________________
From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Zhang,
Hawking <hawking.zh...@amd.com>
Sent: Friday, September 11, 2020 2:02 AM
To: Clements, John <john.cleme...@amd.com>; amd-gfx list
<amd-gfx@lists.freedesktop.org>; Chen, Guchun <guchun.c...@amd.com>
Subject: RE: [PATCH] drm/amdgpu: Update RAS init handling
[AMD Public Use]
+ {
+ dev_warn(psp->adev->dev, "RAS
Init Status: 0x%X\n", ras_cmd->ras_status);
+ }
Please remove the redundant bracket.
Other than that, the patch is
Reviewed-by: Hawking Zhang <hawking.zh...@amd.com>
In addition, please create another patch to move the nbio ras controller irq
source registry to sw_init, which is the consistent as what we did for other ip
blocks, register the irq source in IP sw_init funcs.
Regards,
Hawking
From: Clements, John <john.cleme...@amd.com>
Sent: Friday, September 11, 2020 12:03
To: amd-gfx list <amd-gfx@lists.freedesktop.org>; Chen, Guchun
<guchun.c...@amd.com>; Zhang, Hawking <hawking.zh...@amd.com>
Subject: [PATCH] drm/amdgpu: Update RAS init handling
[AMD Official Use Only - Internal Distribution Only]
Added RAS status check and tear down RAS context if RAS init fails
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
