Re: [PATCH] drm/amd/psp: Fix sysfs: cannot create duplicate filename

[Deucher, Alexander]

[AMD Public Use]

Reviewed-by: Alex Deucher <alexander.deuc...@amd.com>

Want to add a Fixes: tag?
________________________________
From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Andrey 
Grodzovsky <andrey.grodzov...@amd.com>
Sent: Friday, October 16, 2020 10:52 AM
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Grodzovsky, Andrey <andrey.grodzov...@amd.com>; Zhang, Jack (Jian) 
<jack.zha...@amd.com>
Subject: [PATCH] drm/amd/psp: Fix sysfs: cannot create duplicate filename

psp sysfs not cleaned up on driver unload for sienna_cichlid

Signed-off-by: Andrey Grodzovsky <andrey.grodzov...@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index 803b3ab..675b14a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -210,7 +210,8 @@ static int psp_sw_fini(void *handle)
                 adev->psp.ta_fw = NULL;
         }

-       if (adev->asic_type == CHIP_NAVI10)
+       if (adev->asic_type == CHIP_NAVI10 ||
+           adev->asic_type == CHIP_SIENNA_CICHLID)
                 psp_sysfs_fini(adev);

         return 0;
--
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=04%7C01%7Calexander.deucher%40amd.com%7C4b9827047c1f4f1a535908d871e3193a%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637384567500193749%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=klYQ7ZzcmrPbXDeEARNHMTjJMUyZWPSn7N3KTQZ2%2FMc%3D&amp;reserved=0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx