[AMD Official Use Only - Internal Distribution Only] Ah, sorry, I missed that part of the patch.
Alex ________________________________ From: Wentland, Harry <harry.wentl...@amd.com> Sent: Tuesday, November 10, 2020 11:42 AM To: Deucher, Alexander <alexander.deuc...@amd.com>; Wang, Chao-kai (Stylon) <stylon.w...@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org> Cc: Kazlauskas, Nicholas <nicholas.kazlaus...@amd.com> Subject: Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume It's missing the "drm_connector_list_update" call which I assume is important. Stylon, can you review Lee Starnes's patch? Is the drm_connector_list_update call maybe not needed? Thanks, Harry On 2020-11-10 11:26 a.m., Deucher, Alexander wrote: [AMD Official Use Only - Internal Distribution Only] Lee Starnes just sent the exact same patch yesterday. Please review that one: https://patchwork.freedesktop.org/patch/399497/ Alex ________________________________ From: Wentland, Harry <harry.wentl...@amd.com><mailto:harry.wentl...@amd.com> Sent: Tuesday, November 10, 2020 9:27 AM To: Wang, Chao-kai (Stylon) <stylon.w...@amd.com><mailto:stylon.w...@amd.com>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> <amd-gfx@lists.freedesktop.org><mailto:amd-gfx@lists.freedesktop.org> Cc: Kazlauskas, Nicholas <nicholas.kazlaus...@amd.com><mailto:nicholas.kazlaus...@amd.com>; Deucher, Alexander <alexander.deuc...@amd.com><mailto:alexander.deuc...@amd.com> Subject: Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume On 2020-11-10 2:49 a.m., Stylon Wang wrote: > EDID parsing in S3 resume pushes new display modes > to probed_modes list but doesn't consolidate to actual > mode list. This creates a race condition when > amdgpu_dm_connector_ddc_get_modes() re-initializes the > list head without walking the list and results in memory leak. > > Signed-off-by: Stylon Wang <stylon.w...@amd.com><mailto:stylon.w...@amd.com> Looks reasonable to me but haven't had a chance to understand whether this is the best solution. Acked-by: Harry Wentland <harry.wentl...@amd.com><mailto:harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > index 0b6adf23d316..715e0bd489f8 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -2337,7 +2337,8 @@ void amdgpu_dm_update_connector_after_detect( > > drm_connector_update_edid_property(connector, > aconnector->edid); > - drm_add_edid_modes(connector, aconnector->edid); > + aconnector->num_modes = drm_add_edid_modes(connector, > aconnector->edid); > + drm_connector_list_update(connector); > > if (aconnector->dc_link->aux_mode) > drm_dp_cec_set_edid(&aconnector->dm_dp_aux.aux, >
_______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
