Reviewed-by: Lijo Lazar <lijo.la...@amd.com>

On 7/30/2021 8:10 AM, Mario Limonciello wrote:
This is more useful when talking to the SMU team to have the information
in this format, save one less step to manually do it.

Signed-off-by: Mario Limonciello <mario.limoncie...@amd.com>
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 9 +++++++--
  1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
index 20b049ad61c1..bcdefe1157ba 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
@@ -1416,6 +1416,8 @@ static int amdgpu_debugfs_firmware_info_show(struct 
seq_file *m, void *unused)
        struct drm_amdgpu_info_firmware fw_info;
        struct drm_amdgpu_query_fw query_fw;
        struct atom_context *ctx = adev->mode_info.atom_context;
+       uint8_t smu_minor, smu_debug;
+       uint16_t smu_major;
        int ret, i;
static const char *ta_fw_name[TA_FW_TYPE_MAX_INDEX] = {
@@ -1561,8 +1563,11 @@ static int amdgpu_debugfs_firmware_info_show(struct 
seq_file *m, void *unused)
        ret = amdgpu_firmware_info(&fw_info, &query_fw, adev);
        if (ret)
                return ret;
-       seq_printf(m, "SMC feature version: %u, firmware version: 0x%08x\n",
-                  fw_info.feature, fw_info.ver);
+       smu_major = (fw_info.ver >> 16) & 0xffff;
+       smu_minor = (fw_info.ver >> 8) & 0xff;
+       smu_debug = (fw_info.ver >> 0) & 0xff;
+       seq_printf(m, "SMC feature version: %u, firmware version: 0x%08x 
(%d.%d.%d)\n",
+                  fw_info.feature, fw_info.ver, smu_major, smu_minor, 
smu_debug);
/* SDMA */
        query_fw.fw_type = AMDGPU_INFO_FW_SDMA;

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to