RE: [PATCH] drivers/amd/pm: smu13: use local variable adev

[Chen, Guchun]

[Public]

Thank you, Mario.

Reviewed-by: Guchun Chen <guchun.c...@amd.com>

Regards,
Guchun

-----Original Message-----
From: Limonciello, Mario <mario.limoncie...@amd.com> 
Sent: Tuesday, December 14, 2021 11:58 AM
To: amd-gfx@lists.freedesktop.org
Cc: Limonciello, Mario <mario.limoncie...@amd.com>; Chen, Guchun 
<guchun.c...@amd.com>
Subject: [PATCH] drivers/amd/pm: smu13: use local variable adev

Since this variable was made available by the previous commit, use it to make 
function access cleaner.

Suggested-by: Guchun Chen <guchun.c...@amd.com>
Signed-off-by: Mario Limonciello <mario.limoncie...@amd.com>
---
 drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c 
b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
index 677a246212f9..bb3f6072ed30 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
@@ -212,7 +212,7 @@ int smu_v13_0_check_fw_version(struct smu_context *smu)
        if (smu->is_apu)
                adev->pm.fw_version = smu_version;
 
-       switch (smu->adev->ip_versions[MP1_HWIP][0]) {
+       switch (adev->ip_versions[MP1_HWIP][0]) {
        case IP_VERSION(13, 0, 2):
                smu->smc_driver_if_version = SMU13_DRIVER_IF_VERSION_ALDE;
                break;
@@ -221,8 +221,8 @@ int smu_v13_0_check_fw_version(struct smu_context *smu)
                smu->smc_driver_if_version = 
SMU13_DRIVER_IF_VERSION_YELLOW_CARP;
                break;
        default:
-               dev_err(smu->adev->dev, "smu unsupported IP version: 0x%x.\n",
-                       smu->adev->ip_versions[MP1_HWIP][0]);
+               dev_err(adev->dev, "smu unsupported IP version: 0x%x.\n",
+                       adev->ip_versions[MP1_HWIP][0]);
                smu->smc_driver_if_version = SMU13_DRIVER_IF_VERSION_INV;
                break;
        }
@@ -236,11 +236,11 @@ int smu_v13_0_check_fw_version(struct smu_context *smu)
         * of halt driver loading.
         */
        if (if_version != smu->smc_driver_if_version) {
-               dev_info(smu->adev->dev, "smu driver if version = 0x%08x, smu 
fw if version = 0x%08x, "
+               dev_info(adev->dev, "smu driver if version = 0x%08x, smu fw if 
version = 0x%08x, "
                         "smu fw version = 0x%08x (%d.%d.%d)\n",
                         smu->smc_driver_if_version, if_version,
                         smu_version, smu_major, smu_minor, smu_debug);
-               dev_warn(smu->adev->dev, "SMU driver if version not matched\n");
+               dev_warn(adev->dev, "SMU driver if version not matched\n");
        }
 
        return ret;
--
2.25.1