On 2022-03-18 15:00, Nicholas Kazlauskas wrote:
> [Why]
> It changed since dcn30 but the hubbub31 constructor hasn't been
> modified to reflect this.
>
> [How]
> Update the value in the constructor to 0x6 so we're checking the right
> bits for p-state allow.
>
> It worked before by accident, but can falsely assert 0 depending on HW
> state transitions. The most frequent of which appears to be when
> all pipes turn off during IGT tests.
>
> Cc: Harry Wentland <harry.wentl...@amd.com>
> Fixes: d158560fc0e1 ("drm/amd/display: Add pstate verification and recovery
> for DCN31")
> Signed-off-by: Nicholas Kazlauskas <nicholas.kazlaus...@amd.com>
> Reviewed-by: Eric Yang <eric.ya...@amd.com>
Acked-by: Harry Wentland <harry.wentl...@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hubbub.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hubbub.c
> b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hubbub.c
> index 3e6d6ebd199e..51c5f3685470 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hubbub.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hubbub.c
> @@ -1042,5 +1042,7 @@ void hubbub31_construct(struct dcn20_hubbub *hubbub31,
> hubbub31->detile_buf_size = det_size_kb * 1024;
> hubbub31->pixel_chunk_size = pixel_chunk_size_kb * 1024;
> hubbub31->crb_size_segs = config_return_buffer_size_kb /
> DCN31_CRB_SEGMENT_SIZE_KB;
> +
> + hubbub31->debug_test_index_pstate = 0x6;
> }
>
