[AMD Official Use Only - General]
No worries. Let's know if you run into any RAS issue in SRIOV environment.
Regards,
Hawking
-----Original Message-----
From: Wang, YuBiao <yubiao.w...@amd.com>
Sent: Thursday, November 3, 2022 15:56
To: Zhang, Hawking <hawking.zh...@amd.com>; amd-gfx@lists.freedesktop.org;
Feng, Kenneth <kenneth.f...@amd.com>
Cc: Xiao, Jack <jack.x...@amd.com>; Wang, Yang(Kevin) <kevinyang.w...@amd.com>;
Xu, Feifei <feifei...@amd.com>; Chen, Horace <horace.c...@amd.com>; Tuikov,
Luben <luben.tui...@amd.com>; Deucher, Alexander <alexander.deuc...@amd.com>;
Quan, Evan <evan.q...@amd.com>; Koenig, Christian <christian.koe...@amd.com>;
Liu, Monk <monk....@amd.com>
Subject: RE: [PATCH] drm/amdgpu: Disable GFX RAS feature for SRIOV case
Hi Hawking,
Yes I now noticed that. I was sending this patch since I found it as a
regression on my side. So this is caused by IFWI regression instead of a
sriov-only bug. Sorry for the misunderstanding. Thanks!
Regards,
Yubiao
-----Original Message-----
From: Zhang, Hawking <hawking.zh...@amd.com>
Sent: Thursday, November 3, 2022 2:51 PM
To: Zhang, Hawking <hawking.zh...@amd.com>; Wang, YuBiao <yubiao.w...@amd.com>;
amd-gfx@lists.freedesktop.org; Feng, Kenneth <kenneth.f...@amd.com>
Cc: Xiao, Jack <jack.x...@amd.com>; Wang, Yang(Kevin) <kevinyang.w...@amd.com>;
Xu, Feifei <feifei...@amd.com>; Chen, Horace <horace.c...@amd.com>; Tuikov,
Luben <luben.tui...@amd.com>; Deucher, Alexander <alexander.deuc...@amd.com>;
Quan, Evan <evan.q...@amd.com>; Koenig, Christian <christian.koe...@amd.com>;
Liu, Monk <monk....@amd.com>
Subject: RE: [PATCH] drm/amdgpu: Disable GFX RAS feature for SRIOV case
[AMD Official Use Only - General]
Btw, if the concern is the gfx_late_init failure caused by incorrect setting in
IFWI. @Feng, Kenneth already have a workaround.
Regards,
Hawking
-----Original Message-----
From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> On Behalf Of Zhang,
Hawking
Sent: Thursday, November 3, 2022 14:46
To: Wang, YuBiao <yubiao.w...@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Xiao, Jack <jack.x...@amd.com>; Wang, Yang(Kevin) <kevinyang.w...@amd.com>;
Xu, Feifei <feifei...@amd.com>; Chen, Horace <horace.c...@amd.com>; Tuikov,
Luben <luben.tui...@amd.com>; Deucher, Alexander <alexander.deuc...@amd.com>;
Quan, Evan <evan.q...@amd.com>; Koenig, Christian <christian.koe...@amd.com>;
Liu, Monk <monk....@amd.com>
Subject: RE: [PATCH] drm/amdgpu: Disable GFX RAS feature for SRIOV case
[AMD Official Use Only - General]
amdgpu_ras_feature_enable won't send RAS command to firmware if it is invoked
from guest side. The change seems unnecessary.
Regards,
Hawking
-----Original Message-----
From: Wang, YuBiao <yubiao.w...@amd.com>
Sent: Thursday, November 3, 2022 14:39
To: Wang, YuBiao <yubiao.w...@amd.com>; amd-gfx@lists.freedesktop.org; Zhang,
Hawking <hawking.zh...@amd.com>
Cc: Quan, Evan <evan.q...@amd.com>; Chen, Horace <horace.c...@amd.com>; Tuikov,
Luben <luben.tui...@amd.com>; Koenig, Christian <christian.koe...@amd.com>;
Deucher, Alexander <alexander.deuc...@amd.com>; Xiao, Jack <jack.x...@amd.com>;
Liu, Monk <monk....@amd.com>; Xu, Feifei <feifei...@amd.com>; Wang, Yang(Kevin)
<kevinyang.w...@amd.com>
Subject: RE: [PATCH] drm/amdgpu: Disable GFX RAS feature for SRIOV case
Hi Hawking,
This patch is to skip ras init in sriov case. Please help review.
Thanks,
Yubiao
-----Original Message-----
From: YuBiao Wang <yubiao.w...@amd.com>
Sent: Thursday, November 3, 2022 11:12 AM
To: amd-gfx@lists.freedesktop.org
Cc: Andrey Grodzovsky <andrey.grodzov...@amd.com>; Quan, Evan
<evan.q...@amd.com>; Chen, Horace <horace.c...@amd.com>; Tuikov, Luben
<luben.tui...@amd.com>; Koenig, Christian <christian.koe...@amd.com>; Deucher,
Alexander <alexander.deuc...@amd.com>; Xiao, Jack <jack.x...@amd.com>; Zhang,
Hawking <hawking.zh...@amd.com>; Liu, Monk <monk....@amd.com>; Xu, Feifei
<feifei...@amd.com>; Wang, Yang(Kevin) <kevinyang.w...@amd.com>; Wang, YuBiao
<yubiao.w...@amd.com>
Subject: [PATCH] drm/amdgpu: Disable GFX RAS feature for SRIOV case
In sriov guest side doesn't need init ras feature, so skip it.
Signed-off-by: YuBiao Wang <yubiao.w...@amd.com>
---
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
index 84a76c36d9a7..be8ed617e269 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
@@ -4707,7 +4707,7 @@ static int gfx_v11_0_late_init(void *handle)
if (r)
return r;
- if (adev->ip_versions[GC_HWIP][0] == IP_VERSION(11, 0, 3)) {
+ if (!amdgpu_sriov_vf(adev) && adev->ip_versions[GC_HWIP][0] ==
IP_VERSION(11, 0, 3)) {
r = gfx_v11_0_ras_late_init(handle);
if (r)
return r;
--
2.25.1
