[Public]
> -----Original Message-----
> From: Lyude Paul <ly...@redhat.com>
> Sent: Tuesday, November 15, 2022 5:55 AM
> To: Lin, Wayne <wayne....@amd.com>; amd-gfx@lists.freedesktop.org
> Cc: Wentland, Harry <harry.wentl...@amd.com>; sta...@vger.kernel.org;
> Li, Sun peng (Leo) <sunpeng...@amd.com>; Siqueira, Rodrigo
> <rodrigo.sique...@amd.com>; Deucher, Alexander
> <alexander.deuc...@amd.com>; Koenig, Christian
> <christian.koe...@amd.com>; Pan, Xinhui <xinhui....@amd.com>; David
> Airlie <airl...@gmail.com>; Daniel Vetter <dan...@ffwll.ch>; Kazlauskas,
> Nicholas <nicholas.kazlaus...@amd.com>; Pillai, Aurabindo
> <aurabindo.pil...@amd.com>; Li, Roman <roman...@amd.com>; Zuo, Jerry
> <jerry....@amd.com>; Wu, Hersen <hersenxs...@amd.com>; Thomas
> Zimmermann <tzimmerm...@suse.de>; Mahfooz, Hamza
> <hamza.mahf...@amd.com>; Hung, Alex <alex.h...@amd.com>; Francis,
> David <david.fran...@amd.com>; Mikita Lipski <mikita.lip...@amd.com>; Liu,
> Wenjing <wenjing....@amd.com>; open list:DRM DRIVERS <dri-
> de...@lists.freedesktop.org>; open list <linux-ker...@vger.kernel.org>
> Subject: Re: [PATCH 1/2] drm/amdgpu/mst: Stop ignoring error codes and
> deadlocking
>
> On Wed, 2022-11-09 at 09:48 +0000, Lin, Wayne wrote:
> > > }
> > > - if (!drm_dp_mst_atomic_check(state) && !debugfs_overwrite) {
> > > + ret = drm_dp_mst_atomic_check(state);
> > > + if (ret == 0 && !debugfs_overwrite) {
> > > set_dsc_configs_from_fairness_vars(params, vars, count,
> > > k);
> > > - return true;
> > > + return 0;
> > > + } else if (ret == -EDEADLK) {
> > > + return ret;
> >
> > I think we should return here whenever there is an error. Not just for
> > EDEADLK case.
>
> Are we sure about this one? I think we may actually want to make this so it
> returns on ret != -ENOSPC, since we want the function to continue if there's
> no space in the atomic state available so it can try recomputing things with
> compression enabled. On ret == 0 it should return early without doing
> compression, and on ret == -ENOSPC it should just continue the function
> from there
>
Oh, right.. Thanks for saving me from causing disaster : )
> --
> Cheers,
> Lyude Paul (she/her)
> Software Engineer at Red Hat
--
Regards,
Wayne
