Now that framebuffer_check() verifies that the format is properly
supported, there is no need to check it again on amdgpu's inside
helpers.

Therefore, remove the redundant framebuffer format check from the
amdgpu_display_gem_fb_verify_and_init() function, letting
framebuffer_check() perform the framebuffer validation.

Reviewed-by: Simon Ser <cont...@emersion.fr>
Signed-off-by: Maíra Canal <mca...@igalia.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
index b22471b3bd63..611b7a4b086c 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
@@ -1120,16 +1120,6 @@ static int amdgpu_display_gem_fb_verify_and_init(struct 
drm_device *dev,
 
        rfb->base.obj[0] = obj;
        drm_helper_mode_fill_fb_struct(dev, &rfb->base, mode_cmd);
-       /* Verify that the modifier is supported. */
-       if (!drm_any_plane_has_format(dev, mode_cmd->pixel_format,
-                                     mode_cmd->modifier[0])) {
-               drm_dbg_kms(dev,
-                           "unsupported pixel format %p4cc / modifier 
0x%llx\n",
-                           &mode_cmd->pixel_format, mode_cmd->modifier[0]);
-
-               ret = -EINVAL;
-               goto err;
-       }
 
        ret = amdgpu_display_framebuffer_init(dev, rfb, mode_cmd, obj);
        if (ret)
-- 
2.39.0

Reply via email to