cppcheck reports
drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c:1403:76: style:
  Expression is always true because 'else if' condition is opposite to previous 
condition at line 1396. [multiCondition]
   } else if (context->res_ctx.pipe_ctx[i].stream->mall_stream_config.type == 
SUBVP_PHANTOM) {
                                                                           ^
drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c:1396:69: note: first 
condition
   if (context->res_ctx.pipe_ctx[i].stream->mall_stream_config.type != 
SUBVP_PHANTOM) {
                                                                    ^
drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c:1403:76: note: else if 
condition is opposite to first condition
   } else if (context->res_ctx.pipe_ctx[i].stream->mall_stream_config.type == 
SUBVP_PHANTOM) {

It is not necessary to explicitly the check != condition, an else is simplier.

Fixes: 238debcaebe4 ("drm/amd/display: Use DML for MALL SS and Subvp allocation 
calculations")
Signed-off-by: Tom Rix <t...@redhat.com>
---
 drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c 
b/drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c
index 0dc1a03999b6..c96cbd88e20d 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c
@@ -1400,7 +1400,7 @@ static void dcn32_calculate_dlg_params(struct dc *dc, 
struct dc_state *context,
                                        /* SS PSR On: all active surfaces part 
of streams not supporting PSR stored in MALL */
                                        
context->bw_ctx.bw.dcn.mall_ss_psr_active_size_bytes += 
context->res_ctx.pipe_ctx[i].surface_size_in_mall_bytes;
                                }
-                       } else if 
(context->res_ctx.pipe_ctx[i].stream->mall_stream_config.type == SUBVP_PHANTOM) 
{
+                       } else {
                                /* SUBVP: phantom surfaces only stored in MALL 
*/
                                context->bw_ctx.bw.dcn.mall_subvp_size_bytes += 
context->res_ctx.pipe_ctx[i].surface_size_in_mall_bytes;
                        }
-- 
2.26.3

Reply via email to