On Fri, 17 Mar 2023, Alex Deucher wrote: > On Fri, Mar 17, 2023 at 4:23 AM Lee Jones <l...@kernel.org> wrote: > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stat.c:38: warning: > > Cannot understand > > ***************************************************************************** > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stat.c:76: warning: > > Cannot understand > > ***************************************************************************** > > > > Cc: Harry Wentland <harry.wentl...@amd.com> > > Cc: Leo Li <sunpeng...@amd.com> > > Cc: Rodrigo Siqueira <rodrigo.sique...@amd.com> > > Cc: Alex Deucher <alexander.deuc...@amd.com> > > Cc: "Christian König" <christian.koe...@amd.com> > > Cc: "Pan, Xinhui" <xinhui....@amd.com> > > Cc: David Airlie <airl...@gmail.com> > > Cc: Daniel Vetter <dan...@ffwll.ch> > > Cc: Mustapha Ghaddar <mghad...@amd.com> > > Cc: Nicholas Kazlauskas <nicholas.kazlaus...@amd.com> > > Cc: Jasdeep Dhillon <jdhil...@amd.com> > > Cc: amd-gfx@lists.freedesktop.org > > Cc: dri-de...@lists.freedesktop.org > > Signed-off-by: Lee Jones <l...@kernel.org> > > --- > > drivers/gpu/drm/amd/display/dc/core/dc_stat.c | 28 +++++++------------ > > 1 file changed, 10 insertions(+), 18 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stat.c > > b/drivers/gpu/drm/amd/display/dc/core/dc_stat.c > > index 6c06587dd88c2..5f6392ae31a66 100644 > > --- a/drivers/gpu/drm/amd/display/dc/core/dc_stat.c > > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stat.c > > @@ -35,19 +35,15 @@ > > */ > > > > /** > > This looks like it follows some other documentation scheme. Would > probably be better to just remove the extra * and make it not kernel > doc. @Wentland, Harry @Siqueira, Rodrigo ?
Happy to wait for further input. Either demoting from or converting to kerneldoc would be fine. > > - > > ***************************************************************************** > > - * Function: dc_stat_get_dmub_notification > > + * dc_stat_get_dmub_notification > > * > > - * @brief > > - * Calls dmub layer to retrieve dmub notification > > + * Calls dmub layer to retrieve dmub notification > > * > > - * @param > > - * [in] dc: dc structure > > - * [in] notify: dmub notification structure > > + * @dc: dc structure > > + * @notify: dmub notification structure > > * > > - * @return > > + * Returns > > * None > > - > > ***************************************************************************** > > */ > > void dc_stat_get_dmub_notification(const struct dc *dc, struct > > dmub_notification *notify) > > { > > @@ -73,19 +69,15 @@ void dc_stat_get_dmub_notification(const struct dc *dc, > > struct dmub_notification > > } > > > > /** > > - > > ***************************************************************************** > > - * Function: dc_stat_get_dmub_dataout > > + * dc_stat_get_dmub_dataout > > * > > - * @brief > > - * Calls dmub layer to retrieve dmub gpint dataout > > + * Calls dmub layer to retrieve dmub gpint dataout > > * > > - * @param > > - * [in] dc: dc structure > > - * [in] dataout: dmub gpint dataout > > + * @dc: dc structure > > + * @dataout: dmub gpint dataout > > * > > - * @return > > + * Returns > > * None > > - > > ***************************************************************************** > > */ > > void dc_stat_get_dmub_dataout(const struct dc *dc, uint32_t *dataout) > > { > > -- > > 2.40.0.rc1.284.g88254d51c5-goog > > -- Lee Jones [李琼斯]