Hi Jonathan, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm/drm-next] [also build test WARNING on drm-exynos/exynos-drm-next drm-tip/drm-tip next-20230327] [cannot apply to drm-misc/drm-misc-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master v6.3-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jonathan-Kim/drm-amdkfd-display-debug-capabilities/20230328-024632 base: git://anongit.freedesktop.org/drm/drm drm-next patch link: https://lore.kernel.org/r/20230327184339.125016-7-jonathan.kim%40amd.com patch subject: [PATCH 07/34] drm/amdgpu: add gfx9.4.1 hw debug mode enable and disable calls config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230328/202303281322.o1bwzyim-...@intel.com/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/d97444aab7664a04c8975f466a1422a6c0e2efc9 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jonathan-Kim/drm-amdkfd-display-debug-capabilities/20230328-024632 git checkout d97444aab7664a04c8975f466a1422a6c0e2efc9 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 olddefconfig make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/amd/amdgpu/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <l...@intel.com> | Link: https://lore.kernel.org/oe-kbuild-all/202303281322.o1bwzyim-...@intel.com/ All warnings (new ones prefixed by >>): drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c: In function 'suspend_resume_compute_scheduler': >> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:312:53: warning: >> implicit conversion from 'enum amd_hw_ip_block_type' to 'enum >> amd_ip_block_type' [-Wenum-conversion] 312 | return amdgpu_device_ip_wait_for_idle(adev, GC_HWIP); | ^~~~~~~ In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc_types.h:37, from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:30, from drivers/gpu/drm/amd/amdgpu/../include/dm_pp_interface.h:26, from drivers/gpu/drm/amd/amdgpu/amdgpu.h:63, from drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:26: At top level: drivers/gpu/drm/amd/amdgpu/../display/dc/dc_hdmi_types.h:53:22: warning: 'dp_hdmi_dongle_signature_str' defined but not used [-Wunused-const-variable=] 53 | static const uint8_t dp_hdmi_dongle_signature_str[] = "DP-HDMI ADAPTOR"; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +312 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c 281 282 /* 283 * Helper used to suspend/resume gfx pipe for image post process work to set 284 * barrier behaviour. 285 */ 286 static int suspend_resume_compute_scheduler(struct amdgpu_device *adev, bool suspend) 287 { 288 int i, r = 0; 289 290 for (i = 0; i < adev->gfx.num_compute_rings; i++) { 291 struct amdgpu_ring *ring = &adev->gfx.compute_ring[i]; 292 293 if (!(ring && ring->sched.thread)) 294 continue; 295 296 /* stop secheduler and drain ring. */ 297 if (suspend) { 298 drm_sched_stop(&ring->sched, NULL); 299 r = amdgpu_fence_wait_empty(ring); 300 if (r) 301 goto out; 302 } else { 303 drm_sched_start(&ring->sched, false); 304 } 305 } 306 307 out: 308 /* return on resume or failure to drain rings. */ 309 if (!suspend || r) 310 return r; 311 > 312 return amdgpu_device_ip_wait_for_idle(adev, GC_HWIP); 313 } 314 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
