On Tue, Apr 18, 2023 at 07:15:22PM -0300, Guilherme G. Piccoli wrote: > commit 542a56e8eb4467ae654eefab31ff194569db39cd upstream. > > The VCN firmware loading path enables the indirect SRAM mode if it's > advertised as supported. We might have some cases of FW issues that > prevents this mode to working properly though, ending-up in a failed > probe. An example below, observed in the Steam Deck: > > [...] > [drm] failed to load ucode VCN0_RAM(0x3A) > [drm] psp gfx command LOAD_IP_FW(0x6) failed and response status is > (0xFFFF0000) > amdgpu 0000:04:00.0: [drm:amdgpu_ring_test_helper [amdgpu]] *ERROR* ring > vcn_dec_0 test failed (-110) > [drm:amdgpu_device_init.cold [amdgpu]] *ERROR* hw_init of IP block <vcn_v3_0> > failed -110 > amdgpu 0000:04:00.0: amdgpu: amdgpu_device_ip_init failed > amdgpu 0000:04:00.0: amdgpu: Fatal error during GPU init > [...] > > Disabling the VCN block circumvents this, but it's a very invasive > workaround that turns off the entire feature. So, let's add a quirk > on VCN loading that checks for known problematic BIOSes on Vangogh, > so we can proactively disable the indirect SRAM mode and allow the > HW proper probe and VCN IP block to work fine. > > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2385 > Fixes: 82132ecc5432 ("drm/amdgpu: enable Vangogh VCN indirect sram mode") > Fixes: 9a8cc8cabc1e ("drm/amdgpu: enable Vangogh VCN indirect sram mode") > Cc: sta...@vger.kernel.org > Cc: James Zhu <james....@amd.com> > Cc: Leo Liu <leo....@amd.com> > Signed-off-by: Guilherme G. Piccoli <gpicc...@igalia.com> > Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> > --- > > Hi folks, this was build/boot tested on Deck. I've also adjusted the > context, function was reworked on 6.2. > > But what a surprise was for me not see this fix already in 6.1.y, since > I've CCed stable, and the reason for that is really peculiar:
Now queued up, thanks. greg k-h
