On Fri, May 19, 2023 at 06:14:38PM +0530, Srinivasan Shanmugam wrote: > Silencing the compiler from below compilation error: > > drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c:704:23: error: variable > 'mmhub_v1_8_mmea_err_status_reg' is not needed and will not be emitted > [-Werror,-Wunneeded-internal-declaration] > static const uint32_t mmhub_v1_8_mmea_err_status_reg[] = { > ^ > 1 error generated. > > Mark the variable as __maybe_unused to make it clear to clang that this > is expected, so there is no more warning. > > Cc: Christian König <christian.koe...@amd.com> > Cc: Lijo Lazar <lijo.la...@amd.com> > Cc: Luben Tuikov <luben.tui...@amd.com> > Cc: Alex Deucher <alexander.deuc...@amd.com> > Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmu...@amd.com>
Traditionally, this attribute would go between the [] and =, but that is a nit. Can someone please pick this up to unblock our builds on -next? Reviewed-by: Nathan Chancellor <nat...@kernel.org> > --- > drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c > b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c > index 3648994724c2..cba087e529c0 100644 > --- a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c > +++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c > @@ -701,6 +701,7 @@ static void mmhub_v1_8_reset_ras_error_count(struct > amdgpu_device *adev) > mmhub_v1_8_inst_reset_ras_error_count(adev, i); > } > > +__maybe_unused > static const uint32_t mmhub_v1_8_mmea_err_status_reg[] = { > regMMEA0_ERR_STATUS, > regMMEA1_ERR_STATUS, > -- > 2.25.1 >