[AMD Official Use Only - General]
Thanks.
Reviewed-by: Yang Wang <kevinyang.w...@amd.com>
Best Regards,
Kevin
-----Original Message-----
From: Dan Carpenter <dan.carpen...@linaro.org>
Sent: Wednesday, September 27, 2023 8:38 PM
To: Evan Quan <evan.q...@amd.com>; Wang, Yang(Kevin) <kevinyang.w...@amd.com>
Cc: Deucher, Alexander <alexander.deuc...@amd.com>; Koenig, Christian
<christian.koe...@amd.com>; Pan, Xinhui <xinhui....@amd.com>; David Airlie
<airl...@gmail.com>; Daniel Vetter <dan...@ffwll.ch>; Lazar, Lijo
<lijo.la...@amd.com>; Kamal, Asad <asad.ka...@amd.com>; Zhang, Hawking
<hawking.zh...@amd.com>; Wang, Yang(Kevin) <kevinyang.w...@amd.com>;
amd-gfx@lists.freedesktop.org; kernel-janit...@vger.kernel.org
Subject: [PATCH] drm/amd/pm: delete dead code
"ret" was checked earlier inside the loop, so we know it is zero here.
No need to check a second time.
Signed-off-by: Dan Carpenter <dan.carpen...@linaro.org>
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
index 11a6cd96c601..0ffe55e713f3 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
@@ -2346,9 +2346,6 @@ static int mca_get_mca_entry(struct amdgpu_device *adev,
enum amdgpu_mca_error_t
return ret;
}
- if (ret)
- return ret;
-
entry->idx = idx;
entry->type = type;
--
2.39.2
