Fixes: d479ef0d5fbd ("drm/amdgpu: add ras_err_info to identify RAS error 
source")

Please add above comment.

Reviewed-by: Yang Wang <kevinyang.w...@amd.com>

Best Regards,
Kevin

-----Original Message-----
From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> On Behalf Of Stanley.Yang
Sent: Thursday, October 19, 2023 3:00 PM
To: amd-gfx@lists.freedesktop.org
Cc: Yang, Stanley <stanley.y...@amd.com>
Subject: [PATCH Review 1/1] drm/amdgpu: Fix delete nodes that have been relesed

Fix delete nodes that it has been freed.

Signed-off-by: Stanley.Yang <stanley.y...@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index 8831859a2c49..867afbf84223 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
@@ -3499,10 +3499,8 @@ void amdgpu_ras_error_data_fini(struct ras_err_data 
*err_data)  {
        struct ras_err_node *err_node, *tmp;
 
-       list_for_each_entry_safe(err_node, tmp, &err_data->err_node_list, node) 
{
+       list_for_each_entry_safe(err_node, tmp, &err_data->err_node_list, 
+node)
                amdgpu_ras_error_node_release(err_node);
-               list_del(&err_node->node);
-       }
 }
 
 static struct ras_err_node *amdgpu_ras_error_find_node_by_id(struct 
ras_err_data *err_data,
--
2.25.1

Reply via email to