[AMD Official Use Only - General]
Reviewed-by: Kenneth Feng <kenneth.f...@amd.com>
-----Original Message-----
From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> On Behalf Of Liang, Prike
Sent: Friday, November 17, 2023 9:37 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <alexander.deuc...@amd.com>; Li, Sun peng (Leo)
<sunpeng...@amd.com>; Wentland, Harry <harry.wentl...@amd.com>
Subject: RE: [PATCH] drm/amdgpu: correct the amdgpu runtime dereference usage
count
[AMD Official Use Only - General]
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
[AMD Official Use Only - General]
Ping for the review.
Regards,
--Prike
> -----Original Message-----
> From: Liang, Prike <prike.li...@amd.com>
> Sent: Tuesday, November 14, 2023 10:41 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <alexander.deuc...@amd.com>; Liang, Prike
> <prike.li...@amd.com>
> Subject: [PATCH] drm/amdgpu: correct the amdgpu runtime dereference
> usage count
>
> Fix the amdgpu runpm dereference usage count.
>
> Signed-off-by: Prike Liang <prike.li...@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> index 0cacd0b9f8be..4737ada467cc 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> @@ -340,12 +340,12 @@ int amdgpu_display_crtc_set_config(struct
> drm_mode_set *set,
> adev->have_disp_power_ref = true;
> return ret;
> }
> - /* if we have no active crtcs, then drop the power ref
> - * we got before
> + /* if we have no active crtcs, then go to
> + * drop the power ref we got before
> */
> if (!active && adev->have_disp_power_ref) {
> - pm_runtime_put_autosuspend(dev->dev);
> adev->have_disp_power_ref = false;
> + goto out;
> }
>
> out:
> --
> 2.34.1
